scripted-diff: Replace fprintf with tfm::format

MarcoFalke · MarcoFalke · commit fac03ec43a15 · 2019-06-13T10:32:52.000-04:00
-BEGIN VERIFY SCRIPT-
sed -i --regexp-extended -e 's/fprintf\(std(err|out), /tfm::format(std::c\1, /g' $(git grep -l 'fprintf(' -- ':(exclude)src/crypto' ':(exclude)src/leveldb' ':(exclude)src/univalue' ':(exclude)src/secp256k1')
-END VERIFY SCRIPT-

fixup! scripted-diff: Replace fprintf with tfm::format
diff --git a/src/bench/bench_bitcoin.cpp b/src/bench/bench_bitcoin.cpp
@@ -36,7 +36,7 @@ int main(int argc, char** argv)
     SetupBenchArgs();
     std::string error;
     if (!gArgs.ParseParameters(argc, argv, error)) {
-        fprintf(stderr, "Error parsing command line arguments: %s\n", error.c_str());
+        tfm::format(std::cerr, "Error parsing command line arguments: %s\n", error.c_str());
         return EXIT_FAILURE;
     }
 
@@ -53,7 +53,7 @@ int main(int argc, char** argv)
 
     double scaling_factor;
     if (!ParseDouble(scaling_str, &scaling_factor)) {
-        fprintf(stderr, "Error parsing scaling factor as double: %s\n", scaling_str.c_str());
+        tfm::format(std::cerr, "Error parsing scaling factor as double: %s\n", scaling_str.c_str());
         return EXIT_FAILURE;
     }
 
diff --git a/src/bitcoin-cli.cpp b/src/bitcoin-cli.cpp
@@ -101,7 +101,7 @@ static int AppInitRPC(int argc, char* argv[])
     SetupCliArgs();
     std::string error;
     if (!gArgs.ParseParameters(argc, argv, error)) {
-        fprintf(stderr, "Error parsing command line arguments: %s\n", error.c_str());
+        tfm::format(std::cerr, "Error parsing command line arguments: %s\n", error.c_str());
         return EXIT_FAILURE;
     }
     if (argc < 2 || HelpRequested(gArgs) || gArgs.IsArgSet("-version")) {
@@ -115,26 +115,26 @@ static int AppInitRPC(int argc, char* argv[])
             strUsage += "\n" + gArgs.GetHelpMessage();
         }
 
-        fprintf(stdout, "%s", strUsage.c_str());
+        tfm::format(std::cout, "%s", strUsage.c_str());
         if (argc < 2) {
-            fprintf(stderr, "Error: too few parameters\n");
+            tfm::format(std::cerr, "Error: too few parameters\n");
             return EXIT_FAILURE;
         }
         return EXIT_SUCCESS;
     }
     if (!fs::is_directory(GetDataDir(false))) {
-        fprintf(stderr, "Error: Specified data directory \"%s\" does not exist.\n", gArgs.GetArg("-datadir", "").c_str());
+        tfm::format(std::cerr, "Error: Specified data directory \"%s\" does not exist.\n", gArgs.GetArg("-datadir", "").c_str());
         return EXIT_FAILURE;
     }
     if (!gArgs.ReadConfigFiles(error, true)) {
-        fprintf(stderr, "Error reading configuration file: %s\n", error.c_str());
+        tfm::format(std::cerr, "Error reading configuration file: %s\n", error.c_str());
         return EXIT_FAILURE;
     }
     // Check for -testnet or -regtest parameter (BaseParams() calls are only valid after this clause)
     try {
         SelectBaseParams(gArgs.GetChainName());
     } catch (const std::exception& e) {
-        fprintf(stderr, "Error: %s\n", e.what());
+        tfm::format(std::cerr, "Error: %s\n", e.what());
         return EXIT_FAILURE;
     }
     return CONTINUE_EXECUTION;
@@ -508,7 +508,7 @@ int main(int argc, char* argv[])
 #endif
     SetupEnvironment();
     if (!SetupNetworking()) {
-        fprintf(stderr, "Error: Initializing networking failed\n");
+        tfm::format(std::cerr, "Error: Initializing networking failed\n");
         return EXIT_FAILURE;
     }
     event_set_log_callback(&libevent_log_cb);
diff --git a/src/bitcoin-tx.cpp b/src/bitcoin-tx.cpp
@@ -82,15 +82,15 @@ static int AppInitRawTx(int argc, char* argv[])
     SetupBitcoinTxArgs();
     std::string error;
     if (!gArgs.ParseParameters(argc, argv, error)) {
-        fprintf(stderr, "Error parsing command line arguments: %s\n", error.c_str());
+        tfm::format(std::cerr, "Error parsing command line arguments: %s\n", error.c_str());
         return EXIT_FAILURE;
     }
 
     // Check for -testnet or -regtest parameter (Params() calls are only valid after this clause)
     try {
         SelectParams(gArgs.GetChainName());
     } catch (const std::exception& e) {
-        fprintf(stderr, "Error: %s\n", e.what());
+        tfm::format(std::cerr, "Error: %s\n", e.what());
         return EXIT_FAILURE;
     }
 
@@ -104,10 +104,10 @@ static int AppInitRawTx(int argc, char* argv[])
             "\n";
         strUsage += gArgs.GetHelpMessage();
 
-        fprintf(stdout, "%s", strUsage.c_str());
+        tfm::format(std::cout, "%s", strUsage.c_str());
 
         if (argc < 2) {
-            fprintf(stderr, "Error: too few parameters\n");
+            tfm::format(std::cerr, "Error: too few parameters\n");
             return EXIT_FAILURE;
         }
         return EXIT_SUCCESS;
@@ -723,21 +723,21 @@ static void OutputTxJSON(const CTransaction& tx)
     TxToUniv(tx, uint256(), entry);
 
     std::string jsonOutput = entry.write(4);
-    fprintf(stdout, "%s\n", jsonOutput.c_str());
+    tfm::format(std::cout, "%s\n", jsonOutput.c_str());
 }
 
 static void OutputTxHash(const CTransaction& tx)
 {
     std::string strHexHash = tx.GetHash().GetHex(); // the hex-encoded transaction hash (aka the transaction id)
 
-    fprintf(stdout, "%s\n", strHexHash.c_str());
+    tfm::format(std::cout, "%s\n", strHexHash.c_str());
 }
 
 static void OutputTxHex(const CTransaction& tx)
 {
     std::string strHex = EncodeHexTx(tx);
 
-    fprintf(stdout, "%s\n", strHex.c_str());
+    tfm::format(std::cout, "%s\n", strHex.c_str());
 }
 
 static void OutputTx(const CTransaction& tx)
diff --git a/src/bitcoin-wallet.cpp b/src/bitcoin-wallet.cpp
@@ -36,7 +36,7 @@ static bool WalletAppInit(int argc, char* argv[])
     SetupWalletToolArgs();
     std::string error_message;
     if (!gArgs.ParseParameters(argc, argv, error_message)) {
-        fprintf(stderr, "Error parsing command line arguments: %s\n", error_message.c_str());
+        tfm::format(std::cerr, "Error parsing command line arguments: %s\n", error_message.c_str());
         return false;
     }
     if (argc < 2 || HelpRequested(gArgs)) {
@@ -48,15 +48,15 @@ static bool WalletAppInit(int argc, char* argv[])
                                      "  bitcoin-wallet [options] <command>\n\n" +
                                      gArgs.GetHelpMessage();
 
-        fprintf(stdout, "%s", usage.c_str());
+        tfm::format(std::cout, "%s", usage.c_str());
         return false;
     }
 
     // check for printtoconsole, allow -debug
     LogInstance().m_print_to_console = gArgs.GetBoolArg("-printtoconsole", gArgs.GetBoolArg("-debug", false));
 
     if (!fs::is_directory(GetDataDir(false))) {
-        fprintf(stderr, "Error: Specified data directory \"%s\" does not exist.\n", gArgs.GetArg("-datadir", "").c_str());
+        tfm::format(std::cerr, "Error: Specified data directory \"%s\" does not exist.\n", gArgs.GetArg("-datadir", "").c_str());
         return false;
     }
     // Check for -testnet or -regtest parameter (Params() calls are only valid after this clause)
@@ -87,21 +87,21 @@ int main(int argc, char* argv[])
     for(int i = 1; i < argc; ++i) {
         if (!IsSwitchChar(argv[i][0])) {
             if (!method.empty()) {
-                fprintf(stderr, "Error: two methods provided (%s and %s). Only one method should be provided.\n", method.c_str(), argv[i]);
+                tfm::format(std::cerr, "Error: two methods provided (%s and %s). Only one method should be provided.\n", method.c_str(), argv[i]);
                 return EXIT_FAILURE;
             }
             method = argv[i];
         }
     }
 
     if (method.empty()) {
-        fprintf(stderr, "No method provided. Run `bitcoin-wallet -help` for valid methods.\n");
+        tfm::format(std::cerr, "No method provided. Run `bitcoin-wallet -help` for valid methods.\n");
         return EXIT_FAILURE;
     }
 
     // A name must be provided when creating a file
     if (method == "create" && !gArgs.IsArgSet("-wallet")) {
-        fprintf(stderr, "Wallet name must be provided when creating a new wallet.\n");
+        tfm::format(std::cerr, "Wallet name must be provided when creating a new wallet.\n");
         return EXIT_FAILURE;
     }
 
diff --git a/src/bitcoind.cpp b/src/bitcoind.cpp
@@ -70,7 +70,7 @@ static bool AppInit(int argc, char* argv[])
     SetupServerArgs();
     std::string error;
     if (!gArgs.ParseParameters(argc, argv, error)) {
-        fprintf(stderr, "Error parsing command line arguments: %s\n", error.c_str());
+        tfm::format(std::cerr, "Error parsing command line arguments: %s\n", error.c_str());
         return false;
     }
 
@@ -88,33 +88,33 @@ static bool AppInit(int argc, char* argv[])
             strUsage += "\n" + gArgs.GetHelpMessage();
         }
 
-        fprintf(stdout, "%s", strUsage.c_str());
+        tfm::format(std::cout, "%s", strUsage.c_str());
         return true;
     }
 
     try
     {
         if (!fs::is_directory(GetDataDir(false)))
         {
-            fprintf(stderr, "Error: Specified data directory \"%s\" does not exist.\n", gArgs.GetArg("-datadir", "").c_str());
+            tfm::format(std::cerr, "Error: Specified data directory \"%s\" does not exist.\n", gArgs.GetArg("-datadir", "").c_str());
             return false;
         }
         if (!gArgs.ReadConfigFiles(error, true)) {
-            fprintf(stderr, "Error reading configuration file: %s\n", error.c_str());
+            tfm::format(std::cerr, "Error reading configuration file: %s\n", error.c_str());
             return false;
         }
         // Check for -testnet or -regtest parameter (Params() calls are only valid after this clause)
         try {
             SelectParams(gArgs.GetChainName());
         } catch (const std::exception& e) {
-            fprintf(stderr, "Error: %s\n", e.what());
+            tfm::format(std::cerr, "Error: %s\n", e.what());
             return false;
         }
 
         // Error out when loose non-argument tokens are encountered on command line
         for (int i = 1; i < argc; i++) {
             if (!IsSwitchChar(argv[i][0])) {
-                fprintf(stderr, "Error: Command line contains unexpected token '%s', see bitcoind -h for a list of options.\n", argv[i]);
+                tfm::format(std::cerr, "Error: Command line contains unexpected token '%s', see bitcoind -h for a list of options.\n", argv[i]);
                 return false;
             }
         }
@@ -146,18 +146,18 @@ static bool AppInit(int argc, char* argv[])
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wdeprecated-declarations"
 #endif
-            fprintf(stdout, "Bitcoin server starting\n");
+            tfm::format(std::cout, "Bitcoin server starting\n");
 
             // Daemonize
             if (daemon(1, 0)) { // don't chdir (1), do close FDs (0)
-                fprintf(stderr, "Error: daemon() failed: %s\n", strerror(errno));
+                tfm::format(std::cerr, "Error: daemon() failed: %s\n", strerror(errno));
                 return false;
             }
 #if defined(MAC_OSX)
 #pragma GCC diagnostic pop
 #endif
 #else
-            fprintf(stderr, "Error: -daemon is not supported on this operating system\n");
+            tfm::format(std::cerr, "Error: -daemon is not supported on this operating system\n");
             return false;
 #endif // HAVE_DECL_DAEMON
         }
diff --git a/src/noui.cpp b/src/noui.cpp
@@ -37,7 +37,7 @@ bool noui_ThreadSafeMessageBox(const std::string& message, const std::string& ca
 
     if (!fSecure)
         LogPrintf("%s: %s\n", strCaption, message);
-    fprintf(stderr, "%s: %s\n", strCaption.c_str(), message.c_str());
+    tfm::format(std::cerr, "%s: %s\n", strCaption.c_str(), message.c_str());
     return false;
 }
 
diff --git a/src/qt/utilitydialog.cpp b/src/qt/utilitydialog.cpp
@@ -124,7 +124,7 @@ HelpMessageDialog::~HelpMessageDialog()
 void HelpMessageDialog::printToConsole()
 {
     // On other operating systems, the expected action is to print the message to the console.
-    fprintf(stdout, "%s\n", qPrintable(text));
+    tfm::format(std::cout, "%s\n", qPrintable(text));
 }
 
 void HelpMessageDialog::showOrPrint()
diff --git a/src/sync.cpp b/src/sync.cpp
@@ -118,7 +118,7 @@ static void potential_deadlock_detected(const std::pair<void*, void*>& mismatch,
         LogPrintf(" %s\n", i.second.ToString());
     }
     if (g_debug_lockorder_abort) {
-        fprintf(stderr, "Assertion failed: detected inconsistent lock order at %s:%i, details in debug log.\n", __FILE__, __LINE__);
+        tfm::format(std::cerr, "Assertion failed: detected inconsistent lock order at %s:%i, details in debug log.\n", __FILE__, __LINE__);
         abort();
     }
     throw std::logic_error("potential deadlock detected");
@@ -175,15 +175,15 @@ void AssertLockHeldInternal(const char* pszName, const char* pszFile, int nLine,
     for (const std::pair<void*, CLockLocation>& i : g_lockstack)
         if (i.first == cs)
             return;
-    fprintf(stderr, "Assertion failed: lock %s not held in %s:%i; locks held:\n%s", pszName, pszFile, nLine, LocksHeld().c_str());
+    tfm::format(std::cerr, "Assertion failed: lock %s not held in %s:%i; locks held:\n%s", pszName, pszFile, nLine, LocksHeld().c_str());
     abort();
 }
 
 void AssertLockNotHeldInternal(const char* pszName, const char* pszFile, int nLine, void* cs)
 {
     for (const std::pair<void*, CLockLocation>& i : g_lockstack) {
         if (i.first == cs) {
-            fprintf(stderr, "Assertion failed: lock %s held in %s:%i; locks held:\n%s", pszName, pszFile, nLine, LocksHeld().c_str());
+            tfm::format(std::cerr, "Assertion failed: lock %s held in %s:%i; locks held:\n%s", pszName, pszFile, nLine, LocksHeld().c_str());
             abort();
         }
     }
diff --git a/src/util/system.cpp b/src/util/system.cpp
@@ -673,7 +673,7 @@ void PrintExceptionContinue(const std::exception* pex, const char* pszThread)
 {
     std::string message = FormatException(pex, pszThread);
     LogPrintf("\n\n************************\n%s\n", message);
-    fprintf(stderr, "\n\n************************\n%s\n", message.c_str());
+    tfm::format(std::cerr, "\n\n************************\n%s\n", message.c_str());
 }
 
 fs::path GetDefaultDataDir()
@@ -933,7 +933,7 @@ bool ArgsManager::ReadConfigFiles(std::string& error, bool ignore_invalid_keys)
                 }
             }
             for (const std::string& to_include : includeconf) {
-                fprintf(stderr, "warning: -includeconf cannot be used from included files; ignoring -includeconf=%s\n", to_include.c_str());
+                tfm::format(std::cerr, "warning: -includeconf cannot be used from included files; ignoring -includeconf=%s\n", to_include.c_str());
             }
         }
     }
diff --git a/src/wallet/wallettool.cpp b/src/wallet/wallettool.cpp

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ int main(int argc, char** argv)`
`36`	`36`	`SetupBenchArgs();`
`37`	`37`	`std::string error;`
`38`	`38`	`if (!gArgs.ParseParameters(argc, argv, error)) {`
`39`		`- fprintf(stderr, "Error parsing command line arguments: %s\n", error.c_str());`
	`39`	`+ tfm::format(std::cerr, "Error parsing command line arguments: %s\n", error.c_str());`
`40`	`40`	`return EXIT_FAILURE;`
`41`	`41`	`}`
`42`	`42`
`@@ -53,7 +53,7 @@ int main(int argc, char** argv)`
`53`	`53`
`54`	`54`	`double scaling_factor;`
`55`	`55`	`if (!ParseDouble(scaling_str, &scaling_factor)) {`
`56`		`- fprintf(stderr, "Error parsing scaling factor as double: %s\n", scaling_str.c_str());`
	`56`	`+ tfm::format(std::cerr, "Error parsing scaling factor as double: %s\n", scaling_str.c_str());`
`57`	`57`	`return EXIT_FAILURE;`
`58`	`58`	`}`
`59`	`59`
Original file line number	Diff line number	Diff line change
`@@ -82,15 +82,15 @@ static int AppInitRawTx(int argc, char* argv[])`
`82`	`82`	`SetupBitcoinTxArgs();`
`83`	`83`	`std::string error;`
`84`	`84`	`if (!gArgs.ParseParameters(argc, argv, error)) {`
`85`		`- fprintf(stderr, "Error parsing command line arguments: %s\n", error.c_str());`
	`85`	`+ tfm::format(std::cerr, "Error parsing command line arguments: %s\n", error.c_str());`
`86`	`86`	`return EXIT_FAILURE;`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`// Check for -testnet or -regtest parameter (Params() calls are only valid after this clause)`
`90`	`90`	`try {`
`91`	`91`	`SelectParams(gArgs.GetChainName());`
`92`	`92`	`} catch (const std::exception& e) {`
`93`		`- fprintf(stderr, "Error: %s\n", e.what());`
	`93`	`+ tfm::format(std::cerr, "Error: %s\n", e.what());`
`94`	`94`	`return EXIT_FAILURE;`
`95`	`95`	`}`
`96`	`96`
`@@ -104,10 +104,10 @@ static int AppInitRawTx(int argc, char* argv[])`
`104`	`104`	`"\n";`
`105`	`105`	`strUsage += gArgs.GetHelpMessage();`
`106`	`106`
`107`		`- fprintf(stdout, "%s", strUsage.c_str());`
	`107`	`+ tfm::format(std::cout, "%s", strUsage.c_str());`
`108`	`108`
`109`	`109`	`if (argc < 2) {`
`110`		`- fprintf(stderr, "Error: too few parameters\n");`
	`110`	`+ tfm::format(std::cerr, "Error: too few parameters\n");`
`111`	`111`	`return EXIT_FAILURE;`
`112`	`112`	`}`
`113`	`113`	`return EXIT_SUCCESS;`
`@@ -723,21 +723,21 @@ static void OutputTxJSON(const CTransaction& tx)`
`723`	`723`	`TxToUniv(tx, uint256(), entry);`
`724`	`724`
`725`	`725`	`std::string jsonOutput = entry.write(4);`
`726`		`- fprintf(stdout, "%s\n", jsonOutput.c_str());`
	`726`	`+ tfm::format(std::cout, "%s\n", jsonOutput.c_str());`
`727`	`727`	`}`
`728`	`728`
`729`	`729`	`static void OutputTxHash(const CTransaction& tx)`
`730`	`730`	`{`
`731`	`731`	`std::string strHexHash = tx.GetHash().GetHex(); // the hex-encoded transaction hash (aka the transaction id)`
`732`	`732`
`733`		`- fprintf(stdout, "%s\n", strHexHash.c_str());`
	`733`	`+ tfm::format(std::cout, "%s\n", strHexHash.c_str());`
`734`	`734`	`}`
`735`	`735`
`736`	`736`	`static void OutputTxHex(const CTransaction& tx)`
`737`	`737`	`{`
`738`	`738`	`std::string strHex = EncodeHexTx(tx);`
`739`	`739`
`740`		`- fprintf(stdout, "%s\n", strHex.c_str());`
	`740`	`+ tfm::format(std::cout, "%s\n", strHex.c_str());`
`741`	`741`	`}`
`742`	`742`
`743`	`743`	`static void OutputTx(const CTransaction& tx)`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ static bool WalletAppInit(int argc, char* argv[])`
`36`	`36`	`SetupWalletToolArgs();`
`37`	`37`	`std::string error_message;`
`38`	`38`	`if (!gArgs.ParseParameters(argc, argv, error_message)) {`
`39`		`- fprintf(stderr, "Error parsing command line arguments: %s\n", error_message.c_str());`
	`39`	`+ tfm::format(std::cerr, "Error parsing command line arguments: %s\n", error_message.c_str());`
`40`	`40`	`return false;`
`41`	`41`	`}`
`42`	`42`	`if (argc < 2 \|\| HelpRequested(gArgs)) {`
`@@ -48,15 +48,15 @@ static bool WalletAppInit(int argc, char* argv[])`
`48`	`48`	`" bitcoin-wallet [options] <command>\n\n" +`
`49`	`49`	`gArgs.GetHelpMessage();`
`50`	`50`
`51`		`- fprintf(stdout, "%s", usage.c_str());`
	`51`	`+ tfm::format(std::cout, "%s", usage.c_str());`
`52`	`52`	`return false;`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`// check for printtoconsole, allow -debug`
`56`	`56`	`LogInstance().m_print_to_console = gArgs.GetBoolArg("-printtoconsole", gArgs.GetBoolArg("-debug", false));`
`57`	`57`
`58`	`58`	`if (!fs::is_directory(GetDataDir(false))) {`
`59`		`- fprintf(stderr, "Error: Specified data directory \"%s\" does not exist.\n", gArgs.GetArg("-datadir", "").c_str());`
	`59`	`+ tfm::format(std::cerr, "Error: Specified data directory \"%s\" does not exist.\n", gArgs.GetArg("-datadir", "").c_str());`
`60`	`60`	`return false;`
`61`	`61`	`}`
`62`	`62`	`// Check for -testnet or -regtest parameter (Params() calls are only valid after this clause)`
`@@ -87,21 +87,21 @@ int main(int argc, char* argv[])`
`87`	`87`	`for(int i = 1; i < argc; ++i) {`
`88`	`88`	`if (!IsSwitchChar(argv[i][0])) {`
`89`	`89`	`if (!method.empty()) {`
`90`		`- fprintf(stderr, "Error: two methods provided (%s and %s). Only one method should be provided.\n", method.c_str(), argv[i]);`
	`90`	`+ tfm::format(std::cerr, "Error: two methods provided (%s and %s). Only one method should be provided.\n", method.c_str(), argv[i]);`
`91`	`91`	`return EXIT_FAILURE;`
`92`	`92`	`}`
`93`	`93`	`method = argv[i];`
`94`	`94`	`}`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`if (method.empty()) {`
`98`		- fprintf(stderr, "No method provided. Run `bitcoin-wallet -help` for valid methods.\n");
	`98`	+ tfm::format(std::cerr, "No method provided. Run `bitcoin-wallet -help` for valid methods.\n");
`99`	`99`	`return EXIT_FAILURE;`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`// A name must be provided when creating a file`
`103`	`103`	`if (method == "create" && !gArgs.IsArgSet("-wallet")) {`
`104`		`- fprintf(stderr, "Wallet name must be provided when creating a new wallet.\n");`
	`104`	`+ tfm::format(std::cerr, "Wallet name must be provided when creating a new wallet.\n");`
`105`	`105`	`return EXIT_FAILURE;`
`106`	`106`	`}`
`107`	`107`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ static bool AppInit(int argc, char* argv[])`
`70`	`70`	`SetupServerArgs();`
`71`	`71`	`std::string error;`
`72`	`72`	`if (!gArgs.ParseParameters(argc, argv, error)) {`
`73`		`- fprintf(stderr, "Error parsing command line arguments: %s\n", error.c_str());`
	`73`	`+ tfm::format(std::cerr, "Error parsing command line arguments: %s\n", error.c_str());`
`74`	`74`	`return false;`
`75`	`75`	`}`
`76`	`76`
`@@ -88,33 +88,33 @@ static bool AppInit(int argc, char* argv[])`
`88`	`88`	`strUsage += "\n" + gArgs.GetHelpMessage();`
`89`	`89`	`}`
`90`	`90`
`91`		`- fprintf(stdout, "%s", strUsage.c_str());`
	`91`	`+ tfm::format(std::cout, "%s", strUsage.c_str());`
`92`	`92`	`return true;`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`try`
`96`	`96`	`{`
`97`	`97`	`if (!fs::is_directory(GetDataDir(false)))`
`98`	`98`	`{`
`99`		`- fprintf(stderr, "Error: Specified data directory \"%s\" does not exist.\n", gArgs.GetArg("-datadir", "").c_str());`
	`99`	`+ tfm::format(std::cerr, "Error: Specified data directory \"%s\" does not exist.\n", gArgs.GetArg("-datadir", "").c_str());`
`100`	`100`	`return false;`
`101`	`101`	`}`
`102`	`102`	`if (!gArgs.ReadConfigFiles(error, true)) {`
`103`		`- fprintf(stderr, "Error reading configuration file: %s\n", error.c_str());`
	`103`	`+ tfm::format(std::cerr, "Error reading configuration file: %s\n", error.c_str());`
`104`	`104`	`return false;`
`105`	`105`	`}`
`106`	`106`	`// Check for -testnet or -regtest parameter (Params() calls are only valid after this clause)`
`107`	`107`	`try {`
`108`	`108`	`SelectParams(gArgs.GetChainName());`
`109`	`109`	`} catch (const std::exception& e) {`
`110`		`- fprintf(stderr, "Error: %s\n", e.what());`
	`110`	`+ tfm::format(std::cerr, "Error: %s\n", e.what());`
`111`	`111`	`return false;`
`112`	`112`	`}`
`113`	`113`
`114`	`114`	`// Error out when loose non-argument tokens are encountered on command line`
`115`	`115`	`for (int i = 1; i < argc; i++) {`
`116`	`116`	`if (!IsSwitchChar(argv[i][0])) {`
`117`		`- fprintf(stderr, "Error: Command line contains unexpected token '%s', see bitcoind -h for a list of options.\n", argv[i]);`
	`117`	`+ tfm::format(std::cerr, "Error: Command line contains unexpected token '%s', see bitcoind -h for a list of options.\n", argv[i]);`
`118`	`118`	`return false;`
`119`	`119`	`}`
`120`	`120`	`}`
`@@ -146,18 +146,18 @@ static bool AppInit(int argc, char* argv[])`
`146`	`146`	`#pragma GCC diagnostic push`
`147`	`147`	`#pragma GCC diagnostic ignored "-Wdeprecated-declarations"`
`148`	`148`	`#endif`
`149`		`- fprintf(stdout, "Bitcoin server starting\n");`
	`149`	`+ tfm::format(std::cout, "Bitcoin server starting\n");`
`150`	`150`
`151`	`151`	`// Daemonize`
`152`	`152`	`if (daemon(1, 0)) { // don't chdir (1), do close FDs (0)`
`153`		`- fprintf(stderr, "Error: daemon() failed: %s\n", strerror(errno));`
	`153`	`+ tfm::format(std::cerr, "Error: daemon() failed: %s\n", strerror(errno));`
`154`	`154`	`return false;`
`155`	`155`	`}`
`156`	`156`	`#if defined(MAC_OSX)`
`157`	`157`	`#pragma GCC diagnostic pop`
`158`	`158`	`#endif`
`159`	`159`	`#else`
`160`		`- fprintf(stderr, "Error: -daemon is not supported on this operating system\n");`
	`160`	`+ tfm::format(std::cerr, "Error: -daemon is not supported on this operating system\n");`
`161`	`161`	`return false;`
`162`	`162`	`#endif // HAVE_DECL_DAEMON`
`163`	`163`	`}`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ bool noui_ThreadSafeMessageBox(const std::string& message, const std::string& ca`
`37`	`37`
`38`	`38`	`if (!fSecure)`
`39`	`39`	`LogPrintf("%s: %s\n", strCaption, message);`
`40`		`- fprintf(stderr, "%s: %s\n", strCaption.c_str(), message.c_str());`
	`40`	`+ tfm::format(std::cerr, "%s: %s\n", strCaption.c_str(), message.c_str());`
`41`	`41`	`return false;`
`42`	`42`	`}`
`43`	`43`
Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ HelpMessageDialog::~HelpMessageDialog()`
`124`	`124`	`void HelpMessageDialog::printToConsole()`
`125`	`125`	`{`
`126`	`126`	`// On other operating systems, the expected action is to print the message to the console.`
`127`		`- fprintf(stdout, "%s\n", qPrintable(text));`
	`127`	`+ tfm::format(std::cout, "%s\n", qPrintable(text));`
`128`	`128`	`}`
`129`	`129`
`130`	`130`	`void HelpMessageDialog::showOrPrint()`
Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ static void potential_deadlock_detected(const std::pair<void, void>& mismatch,`
`118`	`118`	`LogPrintf(" %s\n", i.second.ToString());`
`119`	`119`	`}`
`120`	`120`	`if (g_debug_lockorder_abort) {`
`121`		`- fprintf(stderr, "Assertion failed: detected inconsistent lock order at %s:%i, details in debug log.\n", __FILE__, __LINE__);`
	`121`	`+ tfm::format(std::cerr, "Assertion failed: detected inconsistent lock order at %s:%i, details in debug log.\n", __FILE__, __LINE__);`
`122`	`122`	`abort();`
`123`	`123`	`}`
`124`	`124`	`throw std::logic_error("potential deadlock detected");`
`@@ -175,15 +175,15 @@ void AssertLockHeldInternal(const char* pszName, const char* pszFile, int nLine,`
`175`	`175`	`for (const std::pair<void*, CLockLocation>& i : g_lockstack)`
`176`	`176`	`if (i.first == cs)`
`177`	`177`	`return;`
`178`		`- fprintf(stderr, "Assertion failed: lock %s not held in %s:%i; locks held:\n%s", pszName, pszFile, nLine, LocksHeld().c_str());`
	`178`	`+ tfm::format(std::cerr, "Assertion failed: lock %s not held in %s:%i; locks held:\n%s", pszName, pszFile, nLine, LocksHeld().c_str());`
`179`	`179`	`abort();`
`180`	`180`	`}`
`181`	`181`
`182`	`182`	`void AssertLockNotHeldInternal(const char* pszName, const char* pszFile, int nLine, void* cs)`
`183`	`183`	`{`
`184`	`184`	`for (const std::pair<void*, CLockLocation>& i : g_lockstack) {`
`185`	`185`	`if (i.first == cs) {`
`186`		`- fprintf(stderr, "Assertion failed: lock %s held in %s:%i; locks held:\n%s", pszName, pszFile, nLine, LocksHeld().c_str());`
	`186`	`+ tfm::format(std::cerr, "Assertion failed: lock %s held in %s:%i; locks held:\n%s", pszName, pszFile, nLine, LocksHeld().c_str());`
`187`	`187`	`abort();`
`188`	`188`	`}`
`189`	`189`	`}`
Original file line number	Diff line number	Diff line change
`@@ -673,7 +673,7 @@ void PrintExceptionContinue(const std::exception* pex, const char* pszThread)`
`673`	`673`	`{`
`674`	`674`	`std::string message = FormatException(pex, pszThread);`
`675`	`675`	`LogPrintf("\n\n************************\n%s\n", message);`
`676`		`- fprintf(stderr, "\n\n************************\n%s\n", message.c_str());`
	`676`	`+ tfm::format(std::cerr, "\n\n************************\n%s\n", message.c_str());`
`677`	`677`	`}`
`678`	`678`
`679`	`679`	`fs::path GetDefaultDataDir()`
`@@ -933,7 +933,7 @@ bool ArgsManager::ReadConfigFiles(std::string& error, bool ignore_invalid_keys)`
`933`	`933`	`}`
`934`	`934`	`}`
`935`	`935`	`for (const std::string& to_include : includeconf) {`
`936`		`- fprintf(stderr, "warning: -includeconf cannot be used from included files; ignoring -includeconf=%s\n", to_include.c_str());`
	`936`	`+ tfm::format(std::cerr, "warning: -includeconf cannot be used from included files; ignoring -includeconf=%s\n", to_include.c_str());`
`937`	`937`	`}`
`938`	`938`	`}`
`939`	`939`	`}`