fuzz: Remove confusing return keyword from CallOneOf

MarcoFalke · MarcoFalke · commit fad0c58c3ecd · 2021-06-07T13:41:13.000+02:00
The return type is already enforced to be void by the
ternary operator:

./test/fuzz/util.h:47:25: error: right operand to ? is void, but left operand is of type *OTHER_TYPE*
    ((i++ == call_index ? callables() : void()), ...);
                        ^ ~~~~~~~~~~~   ~~~~~~
diff --git a/src/test/fuzz/util.h b/src/test/fuzz/util.h
@@ -44,7 +44,7 @@ void CallOneOf(FuzzedDataProvider& fuzzed_data_provider, Callables... callables)
     const size_t call_index{fuzzed_data_provider.ConsumeIntegralInRange<size_t>(0, call_size - 1)};
 
     size_t i{0};
-    return ((i++ == call_index ? callables() : void()), ...);
+    ((i++ == call_index ? callables() : void()), ...);
 }
 
 template <typename Collection>

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ void CallOneOf(FuzzedDataProvider& fuzzed_data_provider, Callables... callables)`
`44`	`44`	`const size_t call_index{fuzzed_data_provider.ConsumeIntegralInRange<size_t>(0, call_size - 1)};`
`45`	`45`
`46`	`46`	`size_t i{0};`
`47`		`- return ((i++ == call_index ? callables() : void()), ...);`
	`47`	`+ ((i++ == call_index ? callables() : void()), ...);`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`template <typename Collection>`