clang-tidy: Apply modernize-deprecated-headers

This can be reproduced according to the developer notes with something
like

( cd ./src/ && ../contrib/devtools/run-clang-tidy.py -p ../bld-cmake -fix -j $(nproc) )

Also, the header related changes were done manually.

Author: MarcoFalke

src/.clang-tidy

@@ -9,6 +9,7 @@ bugprone-lambda-function-name,
 bugprone-unhandled-self-assignment,
 misc-unused-using-decls,
 misc-no-recursion,
+modernize-deprecated-headers,
 modernize-use-default-member-init,
 modernize-use-emplace,
 modernize-use-equals-default,
@@ -29,6 +30,8 @@ readability-redundant-string-init,
 HeaderFilterRegex: '.'
 WarningsAsErrors: '*'
 CheckOptions:
+ - key: modernize-deprecated-headers.CheckHeaderFile
+   value: false
  - key: performance-move-const-arg.CheckTriviallyCopyableMove
    value: false
  - key: bugprone-unhandled-self-assignment.WarnOnlyIfThisHasSuspiciousField

src/base58.cpp

@@ -9,8 +9,8 @@
 #include <util/strencodings.h>
 #include <util/string.h>
 
-#include <assert.h>
-#include <string.h>
+#include <cassert>
+#include <cstring>
 
 #include <limits>
 

src/bech32.cpp

@@ -7,7 +7,7 @@
 #include <util/vector.h>
 
 #include <array>
-#include <assert.h>
+#include <cassert>
 #include <numeric>
 #include <optional>
 

src/bech32.h

@@ -14,7 +14,7 @@
 #ifndef BITCOIN_BECH32_H
 #define BITCOIN_BECH32_H
 
-#include <stdint.h>
+#include <cstdint>
 #include <string>
 #include <vector>
 

src/bench/examples.cpp

@@ -5,7 +5,7 @@
 #include <bench/bench.h>
 
 // Extremely fast-running benchmark:
-#include <math.h>
+#include <cmath>
 
 volatile double sum = 0.0; // volatile, global so not optimized away
 

src/bench/parse_hex.cpp

@@ -4,7 +4,7 @@
 
 #include <bench/bench.h>
 #include <random.h>
-#include <stddef.h>
+#include <cstddef>
 #include <util/strencodings.h>
 #include <cassert>
 #include <optional>

src/bip324.cpp

@@ -16,7 +16,7 @@
 #include <uint256.h>
 
 #include <algorithm>
-#include <assert.h>
+#include <cassert>
 #include <cstdint>
 #include <cstddef>
 #include <iterator>

src/chainparamsbase.cpp

@@ -9,7 +9,7 @@
 #include <tinyformat.h>
 #include <util/chaintype.h>
 
-#include <assert.h>
+#include <cassert>
 
 void SetupChainParamsBaseOptions(ArgsManager& argsman)
 {

src/cluster_linearize.h

@@ -8,7 +8,7 @@
 #include <algorithm>
 #include <numeric>
 #include <optional>
-#include <stdint.h>
+#include <cstdint>
 #include <vector>
 #include <utility>
 

src/coins.h

@@ -16,8 +16,8 @@
 #include <util/check.h>
 #include <util/hasher.h>
 
-#include <assert.h>
-#include <stdint.h>
+#include <cassert>
+#include <cstdint>
 
 #include <functional>
 #include <unordered_map>