Skip to content

Commit fae7b83

Browse files
author
MarcoFalke
committed
lint: Remove forbidden functions from lint-format-strings.py
Given that all of them are forbidden by the test/lint/lint-locale-dependence.py check, they can be removed.
1 parent 2756797 commit fae7b83

File tree

2 files changed

+0
-9
lines changed

2 files changed

+0
-9
lines changed

test/lint/lint-format-strings.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
FUNCTION_NAMES_AND_NUMBER_OF_LEADING_ARGUMENTS = [
1919
'FatalErrorf,0',
20-
'fprintf,1',
2120
'tfm::format,1', # Assuming tfm::::format(std::ostream&, ...
2221
'LogConnectFailure,1',
2322
'LogError,0',
@@ -27,14 +26,7 @@
2726
'LogTrace,1',
2827
'LogPrintf,0',
2928
'LogPrintLevel,2',
30-
'printf,0',
31-
'snprintf,2',
32-
'sprintf,1',
3329
'strprintf,0',
34-
'vfprintf,1',
35-
'vprintf,1',
36-
'vsnprintf,1',
37-
'vsprintf,1',
3830
'WalletLogPrintf,0',
3931
]
4032
RUN_LINT_FILE = 'test/lint/run-lint-format-strings.py'

test/lint/run-lint-format-strings.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import sys
1414

1515
FALSE_POSITIVES = [
16-
("src/dbwrapper.cpp", "vsnprintf(p, limit - p, format, backup_ap)"),
1716
("src/index/base.cpp", "FatalErrorf(const char* fmt, const Args&... args)"),
1817
("src/index/base.h", "FatalErrorf(const char* fmt, const Args&... args)"),
1918
("src/netbase.cpp", "LogConnectFailure(bool manual_connection, const char* fmt, const Args&... args)"),

0 commit comments

Comments
 (0)