cmake, qt, test: Remove problematic code

hebasto · hebasto · commit fb46d57d4e72 · 2024-10-24T11:27:16.000+01:00
The removed code aimed to make Qt's minimal integration plugin DLL
available for `test_bitcoin-qt.exe` on Windows.

However, there are two issues:
1. The code is broken because the destination directory must end with a
   trailing slash (`/`).
2. It is unnecessary because Qt's minimal integration plugin is not
   used on Windows. For more details, please refer to the following
   code.
diff --git a/src/qt/test/CMakeLists.txt b/src/qt/test/CMakeLists.txt
@@ -32,14 +32,6 @@ if(ENABLE_WALLET)
   )
 endif()
 
-if(NOT QT_IS_STATIC)
-  add_custom_command(
-    TARGET test_bitcoin-qt POST_BUILD
-    COMMAND ${CMAKE_COMMAND} -E copy_if_different $<TARGET_PROPERTY:Qt5::QMinimalIntegrationPlugin,LOCATION_$<UPPER_CASE:$<CONFIG>>> $<TARGET_FILE_DIR:test_bitcoin-qt>/plugins/platforms
-    VERBATIM
-  )
-endif()
-
 add_test(NAME test_bitcoin-qt
   COMMAND test_bitcoin-qt
 )

Original file line number	Diff line number	Diff line change
`@@ -32,14 +32,6 @@ if(ENABLE_WALLET)`
`32`	`32`	`)`
`33`	`33`	`endif()`
`34`	`34`
`35`		`-if(NOT QT_IS_STATIC)`
`36`		`- add_custom_command(`
`37`		`- TARGET test_bitcoin-qt POST_BUILD`
`38`		`- COMMAND ${CMAKE_COMMAND} -E copy_if_different $<TARGET_PROPERTY:Qt5::QMinimalIntegrationPlugin,LOCATION_$<UPPER_CASE:$<CONFIG>>> $<TARGET_FILE_DIR:test_bitcoin-qt>/plugins/platforms`
`39`		`- VERBATIM`
`40`		`- )`
`41`		`-endif()`
`42`		`-`
`43`	`35`	`add_test(NAME test_bitcoin-qt`
`44`	`36`	`COMMAND test_bitcoin-qt`
`45`	`37`	`)`