Merge bitcoin/bitcoin#28557: bench: remove NO_THREAD_SAFETY_ANALYSIS usage

d67aa25 bench: drop NO_THREAD_SAFETY_ANALYSIS from disconnected_txs (fanquake)

Pull request description:

  Followup to bitcoin/bitcoin#28385 (comment).

ACKs for top commit:
  MarcoFalke:
    lgtm ACK d67aa25
  hebasto:
    ACK d67aa25, tested on Ubuntu 22.04 with clang 18.0.
  glozow:
    utACK d67aa25

Tree-SHA512: a9a9a8cc70a50d4fbd51779a3203bbc2a29d354b557e8a99cfd649d5998b71ff1087f5bae7170471bed9a917a93c8f3351ae90c9a6e87d88928c35912d007b64

Author: glozow

src/bench/disconnected_transactions.cpp

@@ -98,7 +98,7 @@ static void AddAndRemoveDisconnectedBlockTransactionsAll(benchmark::Bench& bench
     const auto chains{CreateBlocks(/*num_not_shared=*/1)};
     assert(chains.num_shared == BLOCK_VTX_COUNT - 1);
 
-    bench.minEpochIterations(10).run([&]() NO_THREAD_SAFETY_ANALYSIS {
+    bench.minEpochIterations(10).run([&]() {
         Reorg(chains);
     });
 }
@@ -109,7 +109,7 @@ static void AddAndRemoveDisconnectedBlockTransactions90(benchmark::Bench& bench)
     const auto chains{CreateBlocks(/*num_not_shared=*/BLOCK_VTX_COUNT_10PERCENT)};
     assert(chains.num_shared == BLOCK_VTX_COUNT - BLOCK_VTX_COUNT_10PERCENT);
 
-    bench.minEpochIterations(10).run([&]() NO_THREAD_SAFETY_ANALYSIS {
+    bench.minEpochIterations(10).run([&]() {
         Reorg(chains);
     });
 }
@@ -120,7 +120,7 @@ static void AddAndRemoveDisconnectedBlockTransactions10(benchmark::Bench& bench)
     const auto chains{CreateBlocks(/*num_not_shared=*/BLOCK_VTX_COUNT - BLOCK_VTX_COUNT_10PERCENT)};
     assert(chains.num_shared == BLOCK_VTX_COUNT_10PERCENT);
 
-    bench.minEpochIterations(10).run([&]() NO_THREAD_SAFETY_ANALYSIS {
+    bench.minEpochIterations(10).run([&]() {
         Reorg(chains);
     });
 }