Skip to content

Commit ff7f31e

Browse files
committed
[doc] productivity: more advanced git range-diff
1 parent 3a21905 commit ff7f31e

File tree

1 file changed

+14
-2
lines changed

1 file changed

+14
-2
lines changed

doc/productivity.md

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ This will add an `upstream-pull` remote to your git repository, which can be fet
136136

137137
### Diff the diffs with `git range-diff`
138138

139-
It is very common for contributors to rebase their pull requests, or make changes to commits (perhaps in response to review) that are not at the head of their branch. This poses a problem for reviewers as when the contributor force pushes, the reviewer is no longer sure that his previous reviews of commits are still valid (as the commit hashes can now be different even though the diff is semantically the same). `git range-diff` can help solve this problem by diffing the diffs.
139+
It is very common for contributors to rebase their pull requests, or make changes to commits (perhaps in response to review) that are not at the head of their branch. This poses a problem for reviewers as when the contributor force pushes, the reviewer is no longer sure that his previous reviews of commits are still valid (as the commit hashes can now be different even though the diff is semantically the same). [git range-diff](https://git-scm.com/docs/git-range-diff) (Git >= 2.19) can help solve this problem by diffing the diffs.
140140

141141
For example, to identify the differences between your previously reviewed diffs P1-5, and the new diffs P1-2,N3-4 as illustrated below:
142142
```
@@ -152,7 +152,19 @@ You can do:
152152
git range-diff master previously-reviewed-head new-head
153153
```
154154

155-
Note that `git range-diff` also work for rebases.
155+
Note that `git range-diff` also work for rebases:
156+
157+
```
158+
P1--P2--P3--P4--P5 <-- previously-reviewed-head
159+
/
160+
...--m--m1--m2--m3 <-- master
161+
\
162+
P1--P2--N3--N4 <-- new-head (with P3 modified, P4 & P5 squashed)
163+
164+
PREV=P5 N=4 && git range-diff `git merge-base --all HEAD $PREV`...$PREV HEAD~$N...HEAD
165+
```
166+
167+
Where `P5` is the commit you last reviewed and `4` is the number of commits in the new version.
156168

157169
-----
158170

0 commit comments

Comments
 (0)