Merge #110: cmake: add target_capnp_sources headers target

66e12f1 cmake: add target_capnp_sources headers target (Ryan Ofsky)

Pull request description:

  Modify target_capnp_sources function to create a custom cmake target depending on generated capnp headers, that can be listed as an explicit dependency of other c++ targets when cmake's implicit dependency tracking for included files doesn't work.

  This might help fix the build problem encountered bitcoin/bitcoin#30510 (comment)

ACKs for top commit:
  TheCharlatan:
    lgtm ACK 66e12f1

Tree-SHA512: e21cc3c58bf14af2c418f0c50af72f514c4a9358591dc9b63cfa5cec72f658d196fff15d94c9097bc552ee0443b8fcefcb4f99bbad89fe04393955892cdfb094

Author: ryanofsky

cmake/TargetCapnpSources.cmake

@@ -64,6 +64,7 @@ function(target_capnp_sources target include_prefix)
     message(FATAL_ERROR "Target 'Libmultiprocess::mpgen' does not exist.")
   endif()
 
+  set(generated_headers "")
   foreach(capnp_file IN LISTS TCS_UNPARSED_ARGUMENTS)
     add_custom_command(
       OUTPUT ${capnp_file}.c++ ${capnp_file}.h ${capnp_file}.proxy-client.c++ ${capnp_file}.proxy-types.h ${capnp_file}.proxy-server.c++ ${capnp_file}.proxy-types.c++ ${capnp_file}.proxy.h
@@ -77,6 +78,8 @@ function(target_capnp_sources target include_prefix)
       ${CMAKE_CURRENT_BINARY_DIR}/${capnp_file}.proxy-server.c++
       ${CMAKE_CURRENT_BINARY_DIR}/${capnp_file}.proxy-types.c++
     )
+
+    list(APPEND generated_headers ${capnp_file}.h)
   endforeach()
 
   # Translate include_prefix from a source path to a binary path and add it as a
@@ -91,4 +94,11 @@ function(target_capnp_sources target include_prefix)
   if(TARGET Libmultiprocess::multiprocess)
     target_link_libraries(${target} PRIVATE Libmultiprocess::multiprocess)
   endif()
+
+  # Add a custom target that can be specified as a dependency of c++ targets
+  # that include generated headers. It can be necessary to specify these
+  # dependencies explicitly because while cmake detect dependencies of non
+  # generated files on generated headers, it does not reliably detect
+  # dependencies of generated headers on other generated headers.
+  add_custom_target("${target}_headers" DEPENDS ${generated_headers})
 endfunction()