proxy-types: fix clang-tidy bugprone-use-after-move error

ryanofsky · ryanofsky · commit 422923f38485 · 2025-06-19T22:21:02.000-04:00
include/mp/proxy-types.h:203:98: error: 'values' used after it was forwarded [bugprone-use-after-move,-warnings-as-errors]
  203 |         CustomBuildField(TypeList&lt;LocalTypes...&gt;(), Priority&lt;3&gt;(), context, std::forward&lt;Values&gt;(values)...,
      |                                                                                                  ^
include/mp/proxy-types.h:202:9: note: forward occurred here
  202 |     if (CustomHasValue(context, std::forward&lt;Values&gt;(values)...)) {
      |         ^
diff --git a/include/mp/proxy-types.h b/include/mp/proxy-types.h
@@ -191,15 +191,15 @@ void ThrowField(TypeList<std::exception>, InvokeContext& invoke_context, Input&&
 }
 
 template <typename... Values>
-bool CustomHasValue(InvokeContext& invoke_context, Values&&... value)
+bool CustomHasValue(InvokeContext& invoke_context, const Values&... value)
 {
     return true;
 }
 
 template <typename... LocalTypes, typename Context, typename... Values, typename Output>
 void BuildField(TypeList<LocalTypes...>, Context& context, Output&& output, Values&&... values)
 {
-    if (CustomHasValue(context, std::forward<Values>(values)...)) {
+    if (CustomHasValue(context, values...)) {
         CustomBuildField(TypeList<LocalTypes...>(), Priority<3>(), context, std::forward<Values>(values)...,
             std::forward<Output>(output));
     }

Original file line number	Diff line number	Diff line change
`@@ -191,15 +191,15 @@ void ThrowField(TypeList<std::exception>, InvokeContext& invoke_context, Input&&`
`191`	`191`	`}`
`192`	`192`
`193`	`193`	`template <typename... Values>`
`194`		`-bool CustomHasValue(InvokeContext& invoke_context, Values&&... value)`
	`194`	`+bool CustomHasValue(InvokeContext& invoke_context, const Values&... value)`
`195`	`195`	`{`
`196`	`196`	`return true;`
`197`	`197`	`}`
`198`	`198`
`199`	`199`	`template <typename... LocalTypes, typename Context, typename... Values, typename Output>`
`200`	`200`	`void BuildField(TypeList<LocalTypes...>, Context& context, Output&& output, Values&&... values)`
`201`	`201`	`{`
`202`		`- if (CustomHasValue(context, std::forward<Values>(values)...)) {`
	`202`	`+ if (CustomHasValue(context, values...)) {`
`203`	`203`	`CustomBuildField(TypeList<LocalTypes...>(), Priority<3>(), context, std::forward<Values>(values)...,`
`204`	`204`	`std::forward<Output>(output));`
`205`	`205`	`}`