Skip to content

Commit 4abaa98

Browse files
committed
clang-tidy: Fix readability-avoid-nested-conditional-operator check
See: https://clang.llvm.org/extra/clang-tidy/checks/readability/avoid-nested-conditional-operator.html
1 parent 01ef094 commit 4abaa98

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

src/mp/gen.cpp

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -214,8 +214,11 @@ static void Generate(kj::StringPtr src_prefix,
214214
cpp_types << "namespace mp {\n";
215215

216216
std::string guard = output_path;
217-
std::transform(guard.begin(), guard.end(), guard.begin(), [](unsigned char c) {
218-
return ('0' <= c && c <= '9') ? c : ('A' <= c && c <= 'Z') ? c : ('a' <= c && c <= 'z') ? c - 'a' + 'A' : '_';
217+
std::transform(guard.begin(), guard.end(), guard.begin(), [](unsigned char c) -> unsigned char {
218+
if ('0' <= c && c <= '9') return c;
219+
if ('A' <= c && c <= 'Z') return c;
220+
if ('a' <= c && c <= 'z') return c - 'a' + 'A';
221+
return '_';
219222
});
220223

221224
std::ofstream inl(output_path + ".proxy-types.h");
@@ -495,7 +498,13 @@ static void Generate(kj::StringPtr src_prefix,
495498
auto field_type = f.getType();
496499

497500
std::ostringstream field_flags;
498-
field_flags << (!field.param_is_set ? "FIELD_OUT" : field.result_is_set ? "FIELD_IN | FIELD_OUT" : "FIELD_IN");
501+
if (!field.param_is_set) {
502+
field_flags << "FIELD_OUT";
503+
} else if (field.result_is_set) {
504+
field_flags << "FIELD_IN | FIELD_OUT";
505+
} else {
506+
field_flags << "FIELD_IN";
507+
}
499508
if (field.optional) field_flags << " | FIELD_OPTIONAL";
500509
if (field.requested) field_flags << " | FIELD_REQUESTED";
501510
if (BoxedType(field_type)) field_flags << " | FIELD_BOXED";

0 commit comments

Comments
 (0)