You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merge #221: test default PassField impl handles output parameters
6db6696 test In|Out parameter (Novo)
29cf2ad test default PassField impl handles output parameters (Novo)
Pull request description:
This PR adds two test cases to ensure that output parameter results from a server call are correctly captured and included in the response.
The new tests also serve as practical examples of how to work with output parameters and `in|out` parameters in the codebase.
### Testing
Automated coverage is not yet available, see #198.
As a temporary verification method:
- Comment out [these lines](https://github.com/bitcoin-core/libmultiprocess/blob/47d79db8a5528097b408e18f7b0bae11a6702d26/include/mp/proxy-types.h#L308-L310)
and run make check. The new test should fail, confirming it is effective.
- If you then also comment out the newly added tests and rerun make check, it should pass, demonstrating that the lines above were previously uncovered.
ACKs for top commit:
ryanofsky:
Code review ACK 6db6696. Thanks, both changes look good!
Tree-SHA512: c6d0604d41a840e27bb3b039b08516ffca160f4215f46983a462102eaa9a4c09c8b8375715ad7fdc1c1da9bb94387cb2d716a3b9bca8e7a118c81de0ceb00eb7
0 commit comments