Merge #187: ci: have bash scripts explicitly opt out of locale dependence.

3a6db38 ci: rename configs to .bash (Sjors Provoost)
401e0ce ci: add copyright to bash scripts (Sjors Provoost)
e956467 ci: export LC_ALL (Sjors Provoost)

Pull request description:

  Prevents linter issues like reported here: Sjors/bitcoin#90 (comment)

  But probably also just a good idea.

  Also make the use of `#!/usr/bin/env bash` consistent and added a copyright header (mostly for aesthetic reasons).

ACKs for top commit:
  ryanofsky:
    Code review ACK 3a6db38. Thanks!

Tree-SHA512: de4a3fe62126f0f37e9b33c6e443ee07b2968ac8df18b7d91ce482ce63aeab896b216a7efcc638945ef4f83b4429471433c3515b5bbe744fb238bec08792f7af

Author: ryanofsky

.github/workflows/ci.yml

@@ -25,5 +25,5 @@ jobs:
 
       - name: Run CI script
         env:
-          CI_CONFIG: ci/configs/${{ matrix.config }}.sh
+          CI_CONFIG: ci/configs/${{ matrix.config }}.bash
         run: ci/scripts/run.sh

ci/README.md

@@ -16,9 +16,9 @@ All CI is just bash and nix.
 To run jobs locally:
 
 ```bash
-CI_CONFIG=ci/configs/default.sh ci/scripts/run.sh
-CI_CONFIG=ci/configs/llvm.sh    ci/scripts/run.sh
-CI_CONFIG=ci/configs/gnu32.sh   ci/scripts/run.sh
+CI_CONFIG=ci/configs/default.bash ci/scripts/run.sh
+CI_CONFIG=ci/configs/llvm.bash    ci/scripts/run.sh
+CI_CONFIG=ci/configs/gnu32.bash   ci/scripts/run.sh
 ```
 
 By default CI jobs will reuse their build directories. `CI_CLEAN=1` can be specified to delete them before running instead.

ci/configs/default.sh renamed to ci/configs/default.bash

@@ -1,4 +1,11 @@
 #!/usr/bin/env bash
+#
+# Copyright (c) The Bitcoin Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
+export LC_ALL=C.UTF-8
+
 set -o errexit -o nounset -o pipefail -o xtrace
 
 [ "${CI_CONFIG+x}" ] && source "$CI_CONFIG"

ci/configs/gnu32.sh renamed to ci/configs/gnu32.bash

@@ -1,4 +1,11 @@
 #!/usr/bin/env bash
+#
+# Copyright (c) The Bitcoin Core developers
+# Distributed under the MIT software license, see the accompanying
+# file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
+export LC_ALL=C.UTF-8
+
 set -o errexit -o nounset -o pipefail -o xtrace
 
 [ "${CI_CONFIG+x}" ] && source "$CI_CONFIG"