Skip to content

Commit fd4a90d

Browse files
committed
Merge #244: ci: suppress two tidy lint issues
16dfc36 ci: avoid bugprone-unused-return-value lint in test (Sjors Provoost) dacd5ed ci: suppress nontrivial-threadlocal lint in proxy.cpp (Sjors Provoost) Pull request description: Needed for clang-22 tidy job, see: bitcoin/bitcoin#34662 ACKs for top commit: ryanofsky: Code review ACK 16dfc36, just switching to NOLINT to (void) since last Tree-SHA512: fca97015733b88422f895e7a193fe6700f45a1a12904fe5f8857367561d4e2393dc0598373f908b507e8149eb4e9633f797856ff841ea80fb3e924fe786dc70b
2 parents 290702c + 16dfc36 commit fd4a90d

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/mp/proxy.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
namespace mp {
4040

41-
thread_local ThreadContext g_thread_context;
41+
thread_local ThreadContext g_thread_context; // NOLINT(bitcoin-nontrivial-threadlocal)
4242

4343
void LoggingErrorHandler::taskFailed(kj::Exception&& exception)
4444
{

test/mp/test/test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ class TestSetup
9797
client_connection->m_rpc_system->bootstrap(ServerVatId().vat_id).castAs<messages::FooInterface>(),
9898
client_connection.get(), /* destroy_connection= */ client_owns_connection);
9999
if (client_owns_connection) {
100-
client_connection.release();
100+
(void)client_connection.release();
101101
} else {
102102
client_disconnect = [&] { loop.sync([&] { client_connection.reset(); }); };
103103
}

0 commit comments

Comments
 (0)