From 5ed21b483c3c97e7ae1f37d4932e724118e42a83 Mon Sep 17 00:00:00 2001 From: Epic Curious <109078515+epiccurious@users.noreply.github.com> Date: Tue, 13 Aug 2024 15:45:06 -0400 Subject: [PATCH 1/3] refactor(build): redirect error msg to stderr in autogen.sh --- autogen.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/autogen.sh b/autogen.sh index 27417da..0b4e118 100755 --- a/autogen.sh +++ b/autogen.sh @@ -11,5 +11,5 @@ if [ -z ${LIBTOOLIZE} ] && GLIBTOOLIZE="`which glibtoolize 2>/dev/null`"; then export LIBTOOLIZE fi which autoreconf >/dev/null || \ - (echo "configuration failed, please install autoconf first" && exit 1) + (echo "configuration failed, please install autoconf first" >&2 && exit 1) autoreconf --install --force --warnings=all From bdf5e487061a250c9bef653907e6413c01d72102 Mon Sep 17 00:00:00 2001 From: Epic Curious <109078515+epiccurious@users.noreply.github.com> Date: Tue, 13 Aug 2024 15:45:41 -0400 Subject: [PATCH 2/3] refactor(build): improve portability/reliability with command -v --- autogen.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/autogen.sh b/autogen.sh index 0b4e118..4b13021 100755 --- a/autogen.sh +++ b/autogen.sh @@ -10,6 +10,6 @@ if [ -z ${LIBTOOLIZE} ] && GLIBTOOLIZE="`which glibtoolize 2>/dev/null`"; then LIBTOOLIZE="${GLIBTOOLIZE}" export LIBTOOLIZE fi -which autoreconf >/dev/null || \ +command -v autoreconf >/dev/null || \ (echo "configuration failed, please install autoconf first" >&2 && exit 1) autoreconf --install --force --warnings=all From 30c952eaad1bacb9fe929e55b7d6550a5e13df74 Mon Sep 17 00:00:00 2001 From: Epic Curious <109078515+epiccurious@users.noreply.github.com> Date: Wed, 14 Aug 2024 12:41:13 -0400 Subject: [PATCH 3/3] refactor(build): use modern command substitution instead of legacy backticks --- autogen.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/autogen.sh b/autogen.sh index 4b13021..2abc9d0 100755 --- a/autogen.sh +++ b/autogen.sh @@ -6,7 +6,7 @@ set -e srcdir="$(dirname $0)" cd "$srcdir" -if [ -z ${LIBTOOLIZE} ] && GLIBTOOLIZE="`which glibtoolize 2>/dev/null`"; then +if [ -z ${LIBTOOLIZE} ] && GLIBTOOLIZE="$(which glibtoolize 2>/dev/null)"; then LIBTOOLIZE="${GLIBTOOLIZE}" export LIBTOOLIZE fi