Merge #1524: check-abi: explicitly provide public headers

real-or-random · real-or-random · commit 7712a53061b1 · 2024-05-07T10:35:52.000+02:00
dd69556 check-abi: explicitly provide public headers (Jonas Nick) Pull request description: Without this commit, the check-abi shell script outputs false positives because it consider some headers public that are actually not public. ACKs for top commit: real-or-random: ACK dd69556 hebasto: ACK dd69556, tested on Ubuntu 24.04. Tree-SHA512: b26e61639061f5fbbdd47569ba04f91c627feeefc43ec3d529a3ac4012ab6487aa1904bd38100ed190dcaebdffe60895a8c99346720d5dee84a0c457ec3b6f94
diff --git a/tools/check-abi.sh b/tools/check-abi.sh
@@ -49,7 +49,7 @@ checkout_and_build() {
         -DSECP256K1_BUILD_CTIME_TESTS=OFF \
         -DSECP256K1_BUILD_EXAMPLES=OFF
     cmake --build . -j "$(nproc)"
-    abi-dumper src/libsecp256k1.so -o ABI.dump -lver "$2"
+    abi-dumper src/libsecp256k1.so -o ABI.dump -lver "$2" -public-headers ../include/
     cd "$_orig_dir"
 }
 

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ checkout_and_build() {`
`49`	`49`	`-DSECP256K1_BUILD_CTIME_TESTS=OFF \`
`50`	`50`	`-DSECP256K1_BUILD_EXAMPLES=OFF`
`51`	`51`	`cmake --build . -j "$(nproc)"`
`52`		`- abi-dumper src/libsecp256k1.so -o ABI.dump -lver "$2"`
	`52`	`+ abi-dumper src/libsecp256k1.so -o ABI.dump -lver "$2" -public-headers ../include/`
`53`	`53`	`cd "$_orig_dir"`
`54`	`54`	`}`
`55`	`55`