Skip to content

Commit c8206b1

Browse files
Merge #1771: ci: Use Python virtual environment in "x86_64-macos-native" job
f252da7 ci: Use Python virtual environment in "x86_64-macos-native" job (Hennadii Stepanov) Pull request description: Fixes #1768. This PR explicitly sets up a virtual environment instead of using `uv`, as suggested [here](#1768 (comment)), for the following reasons: 1. It does not require granting a third-party action access to the repository. 2. This approach is already used in other parts of the CI framework (it’s unclear why it was missed in #1359 in the first place). ACKs for top commit: real-or-random: ACK f252da7 Tree-SHA512: df167db9b69ea4a055565c64ea0daa8c0d7b6a12510c35c22309f00a192a8cc4fbbdb0920bacd25547ea8c8f6a7853c2603be35234bd2bac88f610ea848f6120
2 parents 115b135 + f252da7 commit c8206b1

File tree

1 file changed

+7
-12
lines changed

1 file changed

+7
-12
lines changed

.github/workflows/ci.yml

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -469,9 +469,14 @@ jobs:
469469
env: ${{ matrix.env_vars }}
470470
run: ./ci/ci.sh
471471

472-
- name: Symbol check
472+
- &SYMBOL_CHECK_MACOS
473+
name: Symbol check
474+
env:
475+
VIRTUAL_ENV: '${{ github.workspace }}/venv'
473476
run: |
474477
python3 --version
478+
python3 -m venv $VIRTUAL_ENV
479+
export PATH="$VIRTUAL_ENV/bin:$PATH"
475480
python3 -m pip install lief
476481
python3 ./tools/symbol-check.py .libs/libsecp256k1.dylib
477482
@@ -512,17 +517,7 @@ jobs:
512517
ln -s $(brew --prefix gcc)/bin/gcc-?? /usr/local/bin/gcc
513518
514519
- *CI_SCRIPT_ON_HOST
515-
516-
- name: Symbol check
517-
env:
518-
VIRTUAL_ENV: '${{ github.workspace }}/venv'
519-
run: |
520-
python3 --version
521-
python3 -m venv $VIRTUAL_ENV
522-
export PATH="$VIRTUAL_ENV/bin:$PATH"
523-
python3 -m pip install lief
524-
python3 ./tools/symbol-check.py .libs/libsecp256k1.dylib
525-
520+
- *SYMBOL_CHECK_MACOS
526521
- *PRINT_LOGS
527522

528523
win64-native:

0 commit comments

Comments
 (0)