Skip to content

Commit 06fe14d

Browse files
fix: auto height, shrink by max height
1 parent 4ef0c40 commit 06fe14d

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/components/banner/Banner.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ type Props = Links & {
2525

2626
const defaultStyles = {
2727
container:
28-
"dark:text-bdp-white dark:shadow-dark-light gap-2 flex items-center justify-between w-full px-2 sm:px-4 shadow-md transition-all duration-200 ease-in-out text-center",
28+
"dark:text-bdp-white dark:shadow-dark-light gap-2 flex items-center justify-between w-full px-2 sm:px-4 shadow-md transition-all duration-200 ease-in-out text-center h-auto opacity-100 max-h-[200px]",
2929
bannerInfoContainer: `flex flex-col flex-[1_1_auto]`,
3030
headingText: "font-semibold text-sm md:text-lg",
3131
bodyText: "text-sm md:text-base",
@@ -49,15 +49,14 @@ export function Banner({
4949
data-has-heading={Boolean(headingText)}
5050
className={cn(
5151
defaultStyles.container,
52-
"data-[has-heading='true']:h-16",
53-
"data-[has-heading='false']:h-12",
54-
"data-[show-banner='false']:h-0 overflow-hidden",
52+
"data-[show-banner='false']:max-h-[0] overflow-hidden",
5553
styles.container,
5654
)}
5755
>
5856
<div
5957
className={cn(
6058
defaultStyles.bannerInfoContainer,
59+
"py-2", // padding here because it cannot be set on the parent due to transitioning height
6160
styles.bannerInfoContainer,
6261
)}
6362
>

0 commit comments

Comments
 (0)