simln-lib/refactor: remove unnecessary &mut references

Author: mubarak23

simln-lib/src/cln.rs

@@ -112,7 +112,7 @@ impl ClnNode {
     /// Fetch channels belonging to the local node, initiated locally if is_source is true, and initiated remotely if
     /// is_source is false. Introduced as a helper function because CLN doesn't have a single API to list all of our
     /// node's channels.
-    async fn node_channels(&mut self, is_source: bool) -> Result<Vec<u64>, LightningError> {
+    async fn node_channels(&self, is_source: bool) -> Result<Vec<u64>, LightningError> {
         let req = if is_source {
             ListchannelsRequest {
                 source: Some(self.info.pubkey.serialize().to_vec()),
@@ -265,7 +265,7 @@ impl LightningNode for ClnNode {
         }
     }
 
-    async fn list_channels(&mut self) -> Result<Vec<u64>, LightningError> {
+    async fn list_channels(&self) -> Result<Vec<u64>, LightningError> {
         let mut node_channels = self.node_channels(true).await?;
         node_channels.extend(self.node_channels(false).await?);
         Ok(node_channels)

simln-lib/src/eclair.rs

@@ -222,7 +222,7 @@ impl LightningNode for EclairNode {
         })
     }
 
-    async fn list_channels(&mut self) -> Result<Vec<u64>, LightningError> {
+    async fn list_channels(&self) -> Result<Vec<u64>, LightningError> {
         let client = self.client.lock().await;
         let channels: ChannelsResponse = client
             .request("channels", None)

simln-lib/src/lib.rs

@@ -341,7 +341,7 @@ pub trait LightningNode: Send {
     async fn get_node_info(&self, node_id: &PublicKey) -> Result<NodeInfo, LightningError>;
     /// Lists all channels, at present only returns a vector of channel capacities in msat because no further
     /// information is required.
-    async fn list_channels(&mut self) -> Result<Vec<u64>, LightningError>;
+    async fn list_channels(&self) -> Result<Vec<u64>, LightningError>;
     /// Get the network graph from the point of view of a given node.
     async fn get_graph(&self) -> Result<Graph, LightningError>;
 }

simln-lib/src/lnd.rs

@@ -260,7 +260,7 @@ impl LightningNode for LndNode {
         }
     }
 
-    async fn list_channels(&mut self) -> Result<Vec<u64>, LightningError> {
+    async fn list_channels(&self) -> Result<Vec<u64>, LightningError> {
         let mut client = self.client.lock().await;
         let channels = client
             .lightning()

simln-lib/src/sim_node.rs

@@ -709,7 +709,7 @@ impl<T: SimNetwork> LightningNode for SimNode<'_, T> {
         Ok(self.network.lock().await.lookup_node(node_id)?.0)
     }
 
-    async fn list_channels(&mut self) -> Result<Vec<u64>, LightningError> {
+    async fn list_channels(&self) -> Result<Vec<u64>, LightningError> {
         Ok(self.network.lock().await.lookup_node(&self.info.pubkey)?.1)
     }
 
@@ -1897,7 +1897,7 @@ mod tests {
 
         // Create a simulated node for the first channel in our network.
         let pk = channels[0].node_1.policy.pubkey;
-        let mut node = SimNode::new(
+        let node = SimNode::new(
             node_info(pk, String::default()),
             sim_network.clone(),
             Arc::new(graph),

simln-lib/src/test_utils.rs

@@ -88,7 +88,7 @@ mock! {
                 shutdown: triggered::Listener,
             ) -> Result<crate::PaymentResult, LightningError>;
         async fn get_node_info(&self, node_id: &PublicKey) -> Result<NodeInfo, LightningError>;
-        async fn list_channels(&mut self) -> Result<Vec<u64>, LightningError>;
+        async fn list_channels(&self) -> Result<Vec<u64>, LightningError>;
         async fn get_graph(&self) -> Result<Graph, LightningError>;
     }
 }