Merge pull request #218 from f3r10/do_not_allow_defined_activity_with_zero_amount

simln-lib/feat: do not allow defined activity with zero amount

Author: carlaKC

simln-lib/src/lib.rs

@@ -582,6 +582,11 @@ impl Simulation {
         }
 
         for payment_flow in self.activity.iter() {
+            if payment_flow.amount_msat.value() == 0 {
+                return Err(LightningError::ValidationError(
+                    "We do not allow defined activity amount_msat with zero values".to_string(),
+                ));
+            }
             // We need every source node that is configured to execute some activity to be included in our set of
             // nodes so that we can execute events on it.
             self.nodes
@@ -1459,10 +1464,18 @@ async fn track_payment_result(
 
 #[cfg(test)]
 mod tests {
-    use crate::{get_payment_delay, test_utils, MutRng, PaymentGenerationError, PaymentGenerator};
+    use crate::{
+        get_payment_delay, test_utils, LightningError, LightningNode, MutRng, NodeInfo,
+        PaymentGenerationError, PaymentGenerator, Simulation,
+    };
+    use async_trait::async_trait;
+    use bitcoin::secp256k1::PublicKey;
     use mockall::mock;
+    use std::collections::HashMap;
     use std::fmt;
+    use std::sync::Arc;
     use std::time::Duration;
+    use tokio::sync::Mutex;
 
     #[test]
     fn create_seeded_mut_rng() {
@@ -1505,6 +1518,27 @@ mod tests {
         }
     }
 
+    mock! {
+        pub LightningNode {}
+        #[async_trait]
+        impl crate::LightningNode for LightningNode {
+            fn get_info(&self) -> &NodeInfo;
+            async fn get_network(&mut self) -> Result<bitcoin::Network, LightningError>;
+            async fn send_payment(
+                    &mut self,
+                    dest: bitcoin::secp256k1::PublicKey,
+                    amount_msat: u64,
+                ) -> Result<lightning::ln::PaymentHash, LightningError>;
+            async fn track_payment(
+                    &mut self,
+                    hash: &lightning::ln::PaymentHash,
+                    shutdown: triggered::Listener,
+                ) -> Result<crate::PaymentResult, LightningError>;
+            async fn get_node_info(&mut self, node_id: &PublicKey) -> Result<NodeInfo, LightningError>;
+            async fn list_channels(&mut self) -> Result<Vec<u64>, LightningError>;
+        }
+    }
+
     #[test]
     fn test_no_payment_delay() {
         let node = test_utils::create_nodes(1, 100_000)
@@ -1559,4 +1593,33 @@ mod tests {
             payment_interval
         );
     }
+
+    #[tokio::test]
+    async fn test_validate_zero_amount_no_valid() {
+        let nodes = test_utils::create_nodes(2, 100_000);
+        let mut node_1 = nodes.first().unwrap().0.clone();
+        let mut node_2 = nodes.get(1).unwrap().0.clone();
+        node_1.features.set_keysend_optional();
+        node_2.features.set_keysend_optional();
+
+        let mock_node_1 = MockLightningNode::new();
+        let mock_node_2 = MockLightningNode::new();
+        let mut clients: HashMap<PublicKey, Arc<Mutex<dyn LightningNode>>> = HashMap::new();
+        clients.insert(node_1.pubkey, Arc::new(Mutex::new(mock_node_1)));
+        clients.insert(node_2.pubkey, Arc::new(Mutex::new(mock_node_2)));
+        let activity_definition = crate::ActivityDefinition {
+            source: node_1,
+            destination: node_2,
+            start_secs: None,
+            count: None,
+            interval_secs: crate::ValueOrRange::Value(0),
+            amount_msat: crate::ValueOrRange::Value(0),
+        };
+        let simulation = Simulation::new(
+            crate::SimulationCfg::new(Some(0), 0, 0.0, None, None),
+            clients,
+            vec![activity_definition],
+        );
+        assert!(simulation.validate_activity().await.is_err());
+    }
 }