incorporate many of zip's suggestions

Author: mplsgrant

.github/workflows/test.yml

@@ -49,9 +49,9 @@ jobs:
           - rpc_test.py
           - services_test.py
           - signet_test.py
+          - simln_test.py
           - scenarios_test.py
           - namespace_admin_test.py
-          - simln_test.py
     steps:
       - uses: actions/checkout@v4
       - uses: azure/[email protected]

resources/networks/hello/node-defaults.yaml

@@ -5,4 +5,4 @@ image:
 
 lnd:
   defaultConfig: |
-    color=#000000
+    color=#000000

resources/plugins/hello/plugin.py

@@ -10,7 +10,7 @@
 from warnet.constants import PLUGIN_ANNEX, AnnexMember, HookValue, WarnetContent
 from warnet.process import run_command
 
-# Tt is common for Warnet objects to have a "mission" label to help query for them in the cluster.
+# It is common for Warnet objects to have a "mission" label to help query them in the cluster.
 MISSION = "hello"
 PRIMARY_CONTAINER = MISSION
 

resources/plugins/simln/README.md

@@ -25,7 +25,7 @@ Since SimLN already has access to those LND connection details, it means you can
 ### Launch activity definitions from the command line
 The SimLN plugin takes "activity" definitions like so:
 
-`./simln/plugin.py launch-activiy '[{\"source\": \"tank-0003-ln\", \"destination\": \"tank-0005-ln\", \"interval_secs\": 1, \"amount_msat\": 2000}]'"''`
+`./simln/plugin.py launch-activity '[{\"source\": \"tank-0003-ln\", \"destination\": \"tank-0005-ln\", \"interval_secs\": 1, \"amount_msat\": 2000}]'"''`
 
 ### Launch activity definitions from within `network.yaml`
 When you initialize a new Warnet network, Warnet will create a new `network.yaml` file.  If your `network.yaml` file includes lightning nodes, then you can use SimLN to produce activity between those nodes like this:
@@ -106,7 +106,7 @@ The SimLN plugin fetches a SimLN docker image from dockerhub. You can generate y
 2. Follow the instructions to build a docker image as detailed int the SimLn repository.
 3. Tag the resulting docker image: `docker tag IMAGEID YOURUSERNAME/sim-ln:VERSION`
 4. Push the tagged image to you dockerhub account.
-5Modify the `values.yaml` file in the plugin's chart to reflect your username and version number:
+5. Modify the `values.yaml` file in the plugin's chart to reflect your username and version number:
 ```YAML
   repository: "YOURUSERNAME/sim-ln"
   tag: "VERSION"

resources/plugins/simln/charts/simln/values.yaml

@@ -1,7 +1,7 @@
 name: "simln"
 image:
-  repository: "mplsgrant/sim-ln"
-  tag: "4d33f24"
+  repository: "bitcoindevproject/simln"
+  tag: "0.2.3"
   pullPolicy: IfNotPresent
 
 workingVolume:

src/warnet/k8s.py

@@ -61,22 +61,6 @@ def get_pod(name: str, namespace: Optional[str] = None) -> V1Pod:
     return sclient.read_namespaced_pod(name=name, namespace=namespace)
 
 
-def get_pods_with_label(label_selector: str, namespace: Optional[str] = None) -> list[V1Pod]:
-    """Get a list of pods by label.
-    Label example: "mission=lightning"
-    """
-    namespace = get_default_namespace_or(namespace)
-    v1 = get_static_client()
-
-    try:
-        pods = v1.list_namespaced_pod(namespace=namespace, label_selector=label_selector)
-        v1_pods = [pod for pod in pods.items]
-        return v1_pods
-    except client.exceptions.ApiException as e:
-        print(f"Error fetching pods: {e}")
-        return []
-
-
 def get_mission(mission: str) -> list[V1Pod]:
     pods = get_pods()
     crew: list[V1Pod] = []

src/warnet/process.py

@@ -1,5 +1,4 @@
 import subprocess
-from time import sleep
 
 
 def run_command(command: str) -> str:
@@ -30,21 +29,3 @@ def stream_command(command: str) -> bool:
     if return_code != 0:
         raise Exception(message)
     return True
-
-
-def wait_for_run(predicate, timeout=5 * 60, interval=5):
-    print(f"Waiting for predicate with timeout {timeout}s and interval {interval}s")
-    print(predicate)
-    while timeout > 0:
-        try:
-            if run_command(predicate):
-                return
-        except Exception:
-            pass
-        sleep(interval)
-        timeout -= interval
-    import inspect
-
-    raise Exception(
-        f"Timed out waiting for Truth from predicate: {inspect.getsource(predicate).strip()}"
-    )