Stop relying on Bash being located at /bin/bash (#580)

Author: hodlinator

resources/images/bitcoin/insecure/entrypoint.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 set -e
 
 if [ "$(echo "$1" | cut -c1)" = "-" ]; then

resources/scripts/connect_logging.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # NO `set -e` here so an error does not exit the script
 
 POD_NAME=$(kubectl get pods --namespace warnet-logging -l "app.kubernetes.io/name=grafana,app.kubernetes.io/instance=loki-grafana" -o jsonpath="{.items[0].metadata.name}")

resources/scripts/setup_user_contexts.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # Function to check if a command exists
 command_exists() {

src/warnet/bitcoin.py

@@ -189,7 +189,7 @@ def get_messages(tank_a: str, tank_b: str, chain: str):
                 import subprocess
 
                 blob = subprocess.run(
-                    cmd, shell=True, capture_output=True, executable="/bin/bash"
+                    cmd, shell=True, capture_output=True, executable="bash"
                 ).stdout
 
                 # Parse the blob

src/warnet/process.py

@@ -2,17 +2,15 @@
 
 
 def run_command(command: str) -> str:
-    result = subprocess.run(
-        command, shell=True, capture_output=True, text=True, executable="/bin/bash"
-    )
+    result = subprocess.run(command, shell=True, capture_output=True, text=True, executable="bash")
     if result.returncode != 0:
         raise Exception(result.stderr)
     return result.stdout
 
 
 def stream_command(command: str) -> bool:
     process = subprocess.Popen(
-        ["/bin/bash", "-c", command],
+        ["bash", "-c", command],
         stdout=subprocess.PIPE,
         stderr=subprocess.STDOUT,
         text=True,