Enable unique lnd root keys and macaroons #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables a warnet to define unique admin credentials for lnd nodes which will be crucial when playing educational games in a lightning warnet. Similar to random RPC passwords for bitcoind, a network can be configured with unique root keys (from which all admin macaroons are derived) and then kubernetes access permissions will keep those secret from users in different namespaces.
Generating macaroons from the root keys still requires
lncli.For the sake of the test, this PR also updates the hard-coded TLS certificate we use for lnd in warnet so
lnclirequests can be made between nodes. Such requests will only work if the default macaroon keys have not been overriden by warnet configuration!