Use taproot outputs to fund lightning channels #741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is to ensure predictable channel open transaction size so the fee rate expected by ln_init gets applied correctly. Using p2wpkh previously, sometimes (1 out of 500) lnd would create a channel open tx that was 1 byte smaller due to variable signature length. This would inadvertently cause the effective fee rate of the tx to increase so much that it would actually interfere with the deterministic channel IDs we need in Warnet.
This change is applied to both lnd and cln and so this PR also adds test coverage for cln.