Skip to content

Commit da828fd

Browse files
committed
WIP: Remove assumeutxo
These patches cause chaos generally when they don't apply. They need manual updating regularly, break any concept of an automated nightly run, complicate the codebase etc. etc. Remove all assumeutxo functionality from benchkit, including snapshot downloading, patching, and various hook enumerations. Also update flake.nix to include capnp for current master builds.
1 parent d0c223e commit da828fd

File tree

19 files changed

+37
-1065
lines changed

19 files changed

+37
-1065
lines changed

Cargo.toml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "benchkit"
3-
version = "0.2.1"
3+
version = "0.3.0"
44
edition = "2021"
55
rust-version = "1.84.1"
66

@@ -10,10 +10,8 @@ clap = { version = "4.5.29", features = ["cargo", "derive", "env"] }
1010
env_logger = "0.11.6"
1111
hwloc = "0.5.0"
1212
regex = "1.10"
13-
indicatif = "0.17.11"
1413
libc = "0.2"
1514
log = "0.4.26"
16-
reqwest = { version = "0.12.14", default-features = false, features = ["blocking", "rustls-tls"] }
1715
serde = { version = "1.0.219", features = ["derive"] }
1816
serde_json = "1.0.138"
1917
serde_yaml = "0.9.34"

README.md

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ A benchmarking toolkit designed for benchmarking Bitcoin Core.
1111
- System performance tuning and monitoring
1212
- Process profiling and perf instrumentation (Linux only)
1313
- Nix flake for integrated build and run shell environment
14-
- AssumeUTXO snapshot management
1514

1615
## Prerequisites
1716

@@ -32,14 +31,12 @@ git clone https://github.com/bitcoin-dev-tools/benchkit.git && cd benchkit
3231
# Optional (Recommended)
3332
nix develop
3433

35-
# Download a signet assumeutxo snapshot
36-
cargo run -- snapshot download signet
3734

3835
# Build bitcoind binaries from config
3936
cargo run -- build
4037

4138
# Ensure you have a signet node accepting connections on 127.0.0.1:39333 e.g.:
42-
# `bitcoind -signet -port=39333 -rpcport=39332 -daemon=1`
39+
# `bitcoind -signet -daemon=1 -port=39333 -rpcport=39334`
4340

4441
# Run demo benchmarks
4542
cargo run -- run --out-dir ./out
@@ -100,22 +97,7 @@ benchkit system tune
10097
benchkit system reset
10198
```
10299

103-
### AssumeUTXO Snapshot Management
104100

105-
```bash
106-
# Download snapshot for specific network
107-
benchkit snapshot download [mainnet|signet]
108-
```
109-
110-
### Patch testing
111-
112-
```bash
113-
# Test the benchcoin patches apply cleanly to all refs
114-
benchkit patch test
115-
116-
# Fetch latest benchkit patches from github
117-
benchkit patch update
118-
```
119101

120102
## Configuration Files
121103

@@ -147,7 +129,7 @@ global:
147129
host: x86_64-linux-gnu
148130

149131
benchmarks:
150-
- name: "assumeutxo signet test sync"
132+
- name: "signet test sync"
151133
network: signet
152134
connect: 127.0.0.1:39333
153135
benchmark:

benchmark.yml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,25 +38,22 @@ global:
3838
scratch: $HOME/.local/state/benchkit/scratch
3939

4040
# Commits to build binaries from (required).
41-
commits: ["af7402ccfa", "d1b583181d"]
41+
commits: ["e221b252465", "8f73d952214"]
4242

4343
# A temporary datadir for Bitcoin Core to use
4444
tmp_data_dir: /tmp/benchkit
4545

4646
# Local benchmark config.
4747
benchmarks:
4848
# benchmark name (required).
49-
- name: "assumeutxo signet test sync"
49+
- name: "signet test sync"
5050

5151
# Bitcoin network to run on (main, test, testnet4, signet, regtest)
5252
network: signet
5353

5454
# An optional address for bitcoind to -connect to for sync
55-
connect: 127.0.0.1:38333
55+
connect: 127.0.0.1:39333
5656

57-
# Hook mode to use (optional, defaults to "assumeutxo")
58-
# Options: "assumeutxo" (uses snapshot syncing), "full_ibd" (full initial block download)
59-
# mode: assumeutxo
6057

6158
# Local benchmark options.
6259
# These override global benchmark options in case of conflict.

config-examples/assumeutxo.yml

Lines changed: 0 additions & 29 deletions
This file was deleted.

config-examples/full-ibd.yml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
---
2-
# Full IBD Mode Example
2+
# Bitcoin Sync Example
33
#
4-
# This example demonstrates the Full IBD (Initial Block Download) mode, which
5-
# performs a complete sync from genesis without using snapshots. This is useful
6-
# for benchmarking the full sync process.
4+
# This example demonstrates benchmarking Bitcoin Core sync process.
75

86
global:
97
benchmark:
@@ -21,18 +19,16 @@ global:
2119
tmp_data_dir: /tmp/benchkit
2220

2321
benchmarks:
24-
- name: "full ibd signet sync"
22+
- name: "signet sync"
2523
network: signet
2624
connect: 127.0.0.1:38333
27-
mode: full_ibd # Use Full IBD mode - no assumeutxo snapshot syncing
2825
benchmark:
2926
command: "bitcoind -stopatheight=1000"
3027
profile: true
3128

32-
- name: "full ibd with dbcache variations"
29+
- name: "signet sync with dbcache variations"
3330
network: signet
3431
connect: 127.0.0.1:38333
35-
mode: full_ibd
3632
benchmark:
3733
command: "bitcoind -dbcache={dbcache} -stopatheight=500"
3834
parameter_lists:

config.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,3 @@ home_dir: $HOME/.local/state/benchkit
55
# The directory intermediate built binaries will be saved to.
66
bin_dir: $HOME/.local/state/benchkit/binaries
77

8-
# The directory containing benchkit patches
9-
patch_dir: $HOME/.local/state/benchkit/patches
10-
11-
# The directory containing assumeutxo snapshots
12-
snapshot_dir: $HOME/.local/state/benchkit/snapshots

flake.nix

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
];
4949
buildInputs = [
5050
boost
51+
capnproto
5152
hwloc
5253
libevent
5354
rust-bin.stable.latest.default

patches/0001-validation-assumeutxo-benchmarking-patches.patch

Lines changed: 0 additions & 193 deletions
This file was deleted.

0 commit comments

Comments
 (0)