Bugfix: scripts/buildtable: Increment found marker *after* processing the header

luke-jr · luke-jr · commit 42770fb6194f · 2016-12-15T04:20:14.000Z
diff --git a/scripts/buildtable.pl b/scripts/buildtable.pl
@@ -115,7 +115,6 @@
 		} else {
 			die "Bad line in $fn preamble";
 		}
-		++$found{$field};
 		die "Extra spaces in $fn" if $val =~ /^\s/;
 		if ($field eq 'BIP') {
 			die "$fn claims to be BIP $val" if $val ne $bipnum;
@@ -163,6 +162,7 @@
 		} elsif (not exists $MiscField{$field}) {
 			die "Unknown field $field in $fn";
 		}
+		++$found{$field};
 	}
 	if (not $found{License}) {
 		die "Missing License in $fn" unless exists $TolerateMissingLicense{$bipnum};

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,6 @@`
`115`	`115`	`} else {`
`116`	`116`	`die "Bad line in $fn preamble";`
`117`	`117`	`}`
`118`		`- ++$found{$field};`
`119`	`118`	`die "Extra spaces in $fn" if $val =~ /^\s/;`
`120`	`119`	`if ($field eq 'BIP') {`
`121`	`120`	`die "$fn claims to be BIP $val" if $val ne $bipnum;`
`@@ -163,6 +162,7 @@`
`163`	`162`	`} elsif (not exists $MiscField{$field}) {`
`164`	`163`	`die "Unknown field $field in $fn";`
`165`	`164`	`}`
	`165`	`+ ++$found{$field};`
`166`	`166`	`}`
`167`	`167`	`if (not $found{License}) {`
`168`	`168`	`die "Missing License in $fn" unless exists $TolerateMissingLicense{$bipnum};`