Skip to content

Commit 5ec9df0

Browse files
committed
BIP-0047: Adjust text to match test vectors
The original implementation of BIP-47 in Samourai Wallet reversed the parameters in the calculation of the HMAC-SHA512 step of notification transaction blinding. This change adjusts the text to match the as-implementend behavior in deployed BIP-47 wallets and the test vectors.
1 parent 3a75853 commit 5ec9df0

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

bip-0047.mediawiki

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
RECENT CHANGES:
2+
* (28 Sep 2017) Adjust text to match test vectors
23
* (19 Apr 2016) Define version 2 payment codes
34
* (17 Apr 2016) Clarify usage of outpoints in notification transactions
4-
* (18 Dec 2015) Update explanations to resolve FAQs
55
66
<pre>
77
BIP: 47
@@ -158,7 +158,7 @@ Note: this procedure is used if Bob uses a version 1 payment code (regardless of
158158
## Alice selects the private key corresponding to the designated pubkey: <pre>a</pre>
159159
## Alice selects the public key associated with Bob's notification address: <pre>B, where B = bG</pre>
160160
## Alice calculates a secret point: <pre>S = aB</pre>
161-
## Alice calculates a 64 byte blinding factor: <pre>s = HMAC-SHA512(x, o)</pre>
161+
## Alice calculates a 64 byte blinding factor: <pre>s = HMAC-SHA512(o, x)</pre>
162162
### "x" is the x value of the secret point
163163
### "o" is the outpoint being spent by the designated input
164164
# Alice serializes her payment code in binary form.

0 commit comments

Comments
 (0)