Skip to content

Commit 77f0817

Browse files
authored
Merge pull request bitcoin#1593 from jonatack/2024-05-bip388-fixups
BIP388 fixups
2 parents 10e5f62 + 4c689f7 commit 77f0817

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

bip-0388.mediawiki

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ We set two fundamental design goals:
6565
* Minimize the amount of information that is shown on screen - so that the user can actually validate it.
6666
* Minimize the number of times the user has to validate such information.
6767
68-
Designing a secure protocol for the coordination of a descriptor wallet among distant parties is also a challenging problem that is out of scope in this document. See [[bip-00129.mediawiki|BIP-129 (Bitcoin Secure Multisig Setup)]] for an approach designed for multisignature wallets. Regardless of the approach, the ability for the user to carefully verify all the details of the spending policies using the hardware signer's screen is a prerequisite for security in adversarial environments.
68+
Designing a secure protocol for the coordination of a descriptor wallet among distant parties is also a challenging problem that is out of scope in this document. See [[bip-0129.mediawiki|BIP-129 (Bitcoin Secure Multisig Setup)]] for an approach designed for multisignature wallets. Regardless of the approach, the ability for the user to carefully verify all the details of the spending policies using the hardware signer's screen is a prerequisite for security in adversarial environments.
6969

7070
=== Policy registration as a solution ===
7171

@@ -136,7 +136,7 @@ A ''wallet descriptor template'' is a <tt>SCRIPT</tt> expression.
136136
* ''always'' followed by either:
137137
** the string <tt>/**</tt>, or
138138
** a string of the form <tt>/<NUM;NUM>/*</tt>, for two distinct decimal numbers <tt>NUM</tt> representing unhardened derivations, or
139-
** any of the additional, implementation-specific valid derivation path patterns (see [[#Optional_derivation_paths|Optional derivation paths]] below).
139+
** any of the additional, implementation-specific valid derivation path patterns (see [[#optional-derivation-paths|Optional derivation paths]] below).
140140
141141
The <tt>/**</tt> in the placeholder template represents commonly used paths for receive/change addresses, and is equivalent to <tt><0;1>/*</tt>.
142142

@@ -294,7 +294,7 @@ Wallet policies are implemented in
294294
* the [https://github.com/digitalbitbox/bitbox02-firmware BitBox02 firmware] since version v9.15.0;
295295
* [https://github.com/Blockstream/Jade Blockstream Jade] since version v1.0.24, via [https://github.com/ElementsProject/libwally-core libwally-core] v1.0.0.
296296
297-
For development and testing purposes, we provide a [[bip-wallet-policies/wallet_policies.py|Python 3.7 reference implementation]] of simple classes to handle wallet policies, and the conversion to/from output script descriptors.
297+
For development and testing purposes, we provide a [[bip-0388/wallet_policies.py|Python 3.7 reference implementation]] of simple classes to handle wallet policies, and the conversion to/from output script descriptors.
298298
The reference implementation is for demonstration purposes only and not to be used in production environments.
299299

300300
==Footnotes==

bip-0388/wallet_policies.py

100644100755
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
#!/usr/bin/env python3
2+
13
from typing import Iterable, List, Mapping, Tuple, Generator
24

35

0 commit comments

Comments
 (0)