BIP341: add brackets to avoid ambiguity due to precendence rules around bipwise ops

ajtowns · ajtowns · commit 93d1b1528592 · 2021-04-14T02:45:56.000+10:00
diff --git a/bip-0341.mediawiki b/bip-0341.mediawiki
@@ -311,7 +311,7 @@ For Bitcoin mainnet and testnet3, these BIPs will be deployed by "version bits"
         walk = block;
         for (i = 0; i < 2016; i++) {
             walk = walk.parent;
-            if (walk.nVersion & 0xE0000000 == 0x20000000 && (walk.nVersion >> bit) & 1 == 1) {
+            if ((walk.nVersion & 0xE0000000) == 0x20000000 && ((walk.nVersion >> bit) & 1) == 1) {
                 count++;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -311,7 +311,7 @@ For Bitcoin mainnet and testnet3, these BIPs will be deployed by "version bits"`
`311`	`311`	`walk = block;`
`312`	`312`	`for (i = 0; i < 2016; i++) {`
`313`	`313`	`walk = walk.parent;`
`314`		`- if (walk.nVersion & 0xE0000000 == 0x20000000 && (walk.nVersion >> bit) & 1 == 1) {`
	`314`	`+ if ((walk.nVersion & 0xE0000000) == 0x20000000 && ((walk.nVersion >> bit) & 1) == 1) {`
`315`	`315`	`count++;`
`316`	`316`	`}`
`317`	`317`	`}`