Skip to content

Commit 9e0fe1a

Browse files
authored
Merge pull request bitcoin#617 from MarcoFalke/Mf1712-bip159rework
bip159: Clarify that there is only one threshold
2 parents 2e1813a + fa9a4f3 commit 9e0fe1a

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

bip-0159.mediawiki

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,18 +31,18 @@ This BIP proposes a new service bit
3131

3232
{|class="wikitable"
3333
|-
34-
| NODE_NETWORK_LIMITED || bit 10 (0x400) || If signaled, the peer <I>MUST</I> be capable of serving at least the last 288 blocks (~2 day / the current minimum limit for Bitcoin Core).
34+
| NODE_NETWORK_LIMITED || bit 10 (0x400) || If signaled, the peer <I>MUST</I> be capable of serving at least the last 288 blocks (~2 days).
3535
|}
3636

37-
A safety buffer of additional 144 blocks to handle chain reorganizations <I>SHOULD</I> be taken into account when connecting to a peer signaling the <code>NODE_NETWORK_LIMITED</code> service bit.
37+
A safety buffer of 144 blocks to handle chain reorganizations <I>SHOULD</I> be taken into account when connecting to a peer signaling the <code>NODE_NETWORK_LIMITED</code> service bit.
3838

3939
=== Address relay ===
4040

4141
Full nodes following this BIP <I>SHOULD</I> relay address/services (<code>addr</code> message) from peers they would connect to (including peers signaling <code>NODE_NETWORK_LIMITED</code>).
4242

4343
=== Counter-measures for peer fingerprinting ===
4444

45-
Peers may have different prune depths (depending on the peers configuration, disk space, etc.) which can result in a fingerprinting weakness (finding the prune depth through getdata requests). NODE_NETWORK_LIMITED supporting peers <I>SHOULD</I> avoid leaking the prune depth and therefore not serve blocks deeper then the signaled <code>NODE_NETWORK_LIMITED</code> thresholds.
45+
Peers may have different prune depths (depending on the peers configuration, disk space, etc.) which can result in a fingerprinting weakness (finding the prune depth through getdata requests). NODE_NETWORK_LIMITED supporting peers <I>SHOULD</I> avoid leaking the prune depth and therefore not serve blocks deeper than the signaled <code>NODE_NETWORK_LIMITED</code> threshold (244 blocks).
4646

4747
=== Risks ===
4848

@@ -56,10 +56,8 @@ This proposal is backward compatible.
5656

5757
== Reference implementation ==
5858

59-
* https://github.com/bitcoin/bitcoin/pull/10387
60-
61-
62-
== References ==
59+
* https://github.com/bitcoin/bitcoin/pull/11740 (signaling)
60+
* https://github.com/bitcoin/bitcoin/pull/10387 (connection and relay)
6361
6462
== Copyright ==
6563

0 commit comments

Comments
 (0)