Skip to content

Commit 437e908

Browse files
committed
depends: swap cctools-x for llvm-x
Only build ld64 from cctools. Disable adhoc codesigning, to avoid non-determinism.
1 parent bab287d commit 437e908

File tree

4 files changed

+33
-17
lines changed

4 files changed

+33
-17
lines changed

depends/hosts/darwin.mk

Lines changed: 24 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ OSX_SDK=$(SDK_PATH)/Xcode-$(XCODE_VERSION)-$(XCODE_BUILD_ID)-extracted-SDK-with-
99
darwin_native_binutils=native_cctools
1010

1111
ifeq ($(strip $(FORCE_USE_SYSTEM_CLANG)),)
12-
# FORCE_USE_SYSTEM_CLANG is empty, so we use our depends-managed, pinned clang
12+
# FORCE_USE_SYSTEM_CLANG is empty, so we use our depends-managed, pinned LLVM
1313
# from llvm.org
1414

1515
# Clang is a dependency of native_cctools when FORCE_USE_SYSTEM_CLANG is empty
@@ -19,7 +19,18 @@ clang_prog=$(build_prefix)/bin/clang
1919
clangxx_prog=$(clang_prog)++
2020
llvm_config_prog=$(build_prefix)/bin/llvm-config
2121

22-
darwin_OBJDUMP=$(build_prefix)/bin/$(host)-objdump
22+
llvm_TOOLS=AR NM OBJDUMP RANLIB STRIP
23+
24+
# Make-only lowercase function
25+
lc = $(subst A,a,$(subst B,b,$(subst C,c,$(subst D,d,$(subst E,e,$(subst F,f,$(subst G,g,$(subst H,h,$(subst I,i,$(subst J,j,$(subst K,k,$(subst L,l,$(subst M,m,$(subst N,n,$(subst O,o,$(subst P,p,$(subst Q,q,$(subst R,r,$(subst S,s,$(subst T,t,$(subst U,u,$(subst V,v,$(subst W,w,$(subst X,x,$(subst Y,y,$(subst Z,z,$1))))))))))))))))))))))))))
26+
27+
# For well-known tools provided by LLVM, make sure that their well-known
28+
# variable is set to the full path of the tool, just like how AC_PATH_{TOO,PROG}
29+
# would.
30+
$(foreach TOOL,$(llvm_TOOLS),$(eval darwin_$(TOOL) = $$(build_prefix)/bin/llvm-$(call lc,$(TOOL))))
31+
32+
# Clang expects dsymutil to be called dsymutil
33+
darwin_DSYMUTIL=$(build_prefix)/bin/dsymutil
2334

2435
else
2536
# FORCE_USE_SYSTEM_CLANG is non-empty, so we use the clang from the user's
@@ -40,19 +51,14 @@ llvm_config_prog=$(shell $(SHELL) $(.SHELLFLAGS) "command -v llvm-config")
4051

4152
llvm_lib_dir=$(shell $(llvm_config_prog) --libdir)
4253

54+
darwin_AR=$(shell $(SHELL) $(.SHELLFLAGS) "command -v llvm-ar")
55+
darwin_DSYMUTIL=$(shell $(SHELL) $(.SHELLFLAGS) "command -v dsymutil")
56+
darwin_NM=$(shell $(SHELL) $(.SHELLFLAGS) "command -v llvm-nm")
4357
darwin_OBJDUMP=$(shell $(SHELL) $(.SHELLFLAGS) "command -v llvm-objdump")
58+
darwin_RANLIB=$(shell $(SHELL) $(.SHELLFLAGS) "command -v llvm-ranlib")
59+
darwin_STRIP=$(shell $(SHELL) $(.SHELLFLAGS) "command -v llvm-strip")
4460
endif
4561

46-
cctools_TOOLS=AR RANLIB STRIP NM DSYMUTIL
47-
48-
# Make-only lowercase function
49-
lc = $(subst A,a,$(subst B,b,$(subst C,c,$(subst D,d,$(subst E,e,$(subst F,f,$(subst G,g,$(subst H,h,$(subst I,i,$(subst J,j,$(subst K,k,$(subst L,l,$(subst M,m,$(subst N,n,$(subst O,o,$(subst P,p,$(subst Q,q,$(subst R,r,$(subst S,s,$(subst T,t,$(subst U,u,$(subst V,v,$(subst W,w,$(subst X,x,$(subst Y,y,$(subst Z,z,$1))))))))))))))))))))))))))
50-
51-
# For well-known tools provided by cctools, make sure that their well-known
52-
# variable is set to the full path of the tool, just like how AC_PATH_{TOO,PROG}
53-
# would.
54-
$(foreach TOOL,$(cctools_TOOLS),$(eval darwin_$(TOOL) = $$(build_prefix)/bin/$$(host)-$(call lc,$(TOOL))))
55-
5662
# Flag explanations:
5763
#
5864
# -mlinker-version
@@ -79,6 +85,11 @@ $(foreach TOOL,$(cctools_TOOLS),$(eval darwin_$(TOOL) = $$(build_prefix)/bin/$$(
7985
#
8086
# Indicate to the linker the platform, the oldest supported version,
8187
# and the SDK used.
88+
#
89+
# -no_adhoc_codesign
90+
#
91+
# Disable adhoc codesigning (for now) when using LLVM tooling, to avoid
92+
# non-determinism issues with the Identifier field.
8293

8394
darwin_CC=env -u C_INCLUDE_PATH -u CPLUS_INCLUDE_PATH \
8495
-u OBJC_INCLUDE_PATH -u OBJCPLUS_INCLUDE_PATH -u CPATH \
@@ -104,6 +115,7 @@ darwin_LDFLAGS=-Wl,-platform_version,macos,$(OSX_MIN_VERSION),$(OSX_SDK_VERSION)
104115
ifneq ($(build_os),darwin)
105116
darwin_CFLAGS += -mlinker-version=$(LD64_VERSION)
106117
darwin_CXXFLAGS += -mlinker-version=$(LD64_VERSION)
118+
darwin_LDFLAGS += -Wl,-no_adhoc_codesign
107119
endif
108120

109121
darwin_release_CFLAGS=-O2

depends/packages/native_cctools.mk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@ define $(package)_config_cmds
2727
endef
2828

2929
define $(package)_build_cmds
30-
$(MAKE)
30+
$(MAKE) -C ld64
3131
endef
3232

3333
define $(package)_stage_cmds
34-
$(MAKE) DESTDIR=$($(package)_staging_dir) install
34+
$(MAKE) DESTDIR=$($(package)_staging_dir) install -C ld64/src/ld
3535
endef
3636

3737
define $(package)_postprocess_cmds

depends/packages/native_llvm.mk

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,13 @@ define $(package)_stage_cmds
1616
mkdir -p $($(package)_staging_prefix_dir)/include/llvm-c && \
1717
cp bin/clang $($(package)_staging_prefix_dir)/bin/ && \
1818
cp -P bin/clang++ $($(package)_staging_prefix_dir)/bin/ && \
19-
cp bin/dsymutil $($(package)_staging_prefix_dir)/bin/$(host)-dsymutil && \
19+
cp bin/dsymutil $($(package)_staging_prefix_dir)/bin/dsymutil && \
20+
cp bin/llvm-ar $($(package)_staging_prefix_dir)/bin/llvm-ar && \
2021
cp bin/llvm-config $($(package)_staging_prefix_dir)/bin/ && \
21-
cp bin/llvm-objdump $($(package)_staging_prefix_dir)/bin/$(host)-objdump && \
22+
cp bin/llvm-nm $($(package)_staging_prefix_dir)/bin/llvm-nm && \
23+
cp bin/llvm-objdump $($(package)_staging_prefix_dir)/bin/llvm-objdump && \
24+
cp bin/llvm-ranlib $($(package)_staging_prefix_dir)/bin/llvm-ranlib && \
25+
cp bin/llvm-strip $($(package)_staging_prefix_dir)/bin/llvm-strip && \
2226
cp include/llvm-c/ExternC.h $($(package)_staging_prefix_dir)/include/llvm-c && \
2327
cp include/llvm-c/lto.h $($(package)_staging_prefix_dir)/include/llvm-c && \
2428
cp lib/libLTO.so $($(package)_staging_prefix_dir)/lib/ && \

depends/packages/qt.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ ifneq ($(build_os),darwin)
139139
$(package)_config_opts_darwin += -xplatform macx-clang-linux
140140
$(package)_config_opts_darwin += -device-option MAC_SDK_PATH=$(OSX_SDK)
141141
$(package)_config_opts_darwin += -device-option MAC_SDK_VERSION=$(OSX_SDK_VERSION)
142-
$(package)_config_opts_darwin += -device-option CROSS_COMPILE="$(host)-"
142+
$(package)_config_opts_darwin += -device-option CROSS_COMPILE="llvm-"
143143
$(package)_config_opts_darwin += -device-option MAC_TARGET=$(host)
144144
$(package)_config_opts_darwin += -device-option XCODE_VERSION=$(XCODE_VERSION)
145145
endif

0 commit comments

Comments
 (0)