Skip to content

Commit 7b19dce

Browse files
MarcoFalkeRandyMcMillan
authored andcommitted
doc: Move CI-must-pass requirement into readme section
Seems fine to state it clearly once.
1 parent eefdade commit 7b19dce

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ in Python.
5656
These tests can be run (if the [test dependencies](/test) are installed) with: `build/test/functional/test_runner.py`
5757
(assuming `build` is your build directory).
5858

59-
The CI (Continuous Integration) systems make sure that every pull request is built for Windows, Linux, and macOS,
60-
and that unit/sanity tests are run automatically.
59+
The CI (Continuous Integration) systems make sure that every pull request is tested on Windows, Linux, and macOS.
60+
The CI must pass on all commits before merge to avoid unrelated CI failures on new pull requests.
6161

6262
### Manual Quality Assurance (QA) Testing
6363

doc/developer-notes.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -798,12 +798,6 @@ General Bitcoin Core
798798
- *Rationale*: RPC allows for better automatic testing. The test suite for
799799
the GUI is very limited.
800800

801-
- Make sure pull requests pass CI before merging.
802-
803-
- *Rationale*: Makes sure that they pass thorough testing, and that the tester will keep passing
804-
on the master branch. Otherwise, all new pull requests will start failing the tests, resulting in
805-
confusion and mayhem.
806-
807801
Logging
808802
-------
809803

0 commit comments

Comments
 (0)