Bugfix: GUI/OptionsDialog: Set stretch factor on spacers so window resizes avoid weird spacing

Author: luke-jr

src/qt/optionsdialog.cpp

@@ -64,7 +64,7 @@ void OptionsDialog::FixTabOrder(QWidget * const o)
     prevwidget = o;
 }
 
-void OptionsDialog::CreateOptionUI(QBoxLayout * const layout, QWidget * const o, const QString& text, QLayout *horizontalLayout)
+void OptionsDialog::CreateOptionUI(QBoxLayout * const layout, QWidget * const o, const QString& text, QBoxLayout *horizontalLayout)
 {
     QWidget * const parent = o->parentWidget();
     const QStringList text_parts = text.split("%s");
@@ -90,9 +90,7 @@ void OptionsDialog::CreateOptionUI(QBoxLayout * const layout, QWidget * const o,
 
     horizontalLayout->addWidget(labelAfter);
 
-    QSpacerItem * const horizontalSpacer = new QSpacerItem(40, 20, QSizePolicy::Expanding, QSizePolicy::Minimum);
-
-    horizontalLayout->addItem(horizontalSpacer);
+    horizontalLayout->addStretch(1);
 
     layout->addLayout(horizontalLayout);
 

src/qt/optionsdialog.h

@@ -18,7 +18,7 @@ class QBoxLayout;
 class QCheckBox;
 class QDataWidgetMapper;
 class QDoubleSpinBox;
-class QLayout;
+class QBoxLayout;
 class QRadioButton;
 class QSpinBox;
 class QString;
@@ -96,7 +96,7 @@ private Q_SLOTS:
 
     QWidget *prevwidget{nullptr};
     void FixTabOrder(QWidget *);
-    void CreateOptionUI(QBoxLayout *, QWidget *, const QString& text, QLayout *horizontalLayout = nullptr);
+    void CreateOptionUI(QBoxLayout *, QWidget *, const QString& text, QBoxLayout *horizontalLayout = nullptr);
 
     QCheckBox *walletrbf;