Advertise temporary REPLACE_BY_FEE service bit (when appropriate)

Author: luke-jr

src/init.cpp

@@ -1572,6 +1572,10 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info)
         LogPrintf("* Flushing caches if available system memory drops below %s MiB\n", g_low_memory_threshold / 1024 / 1024);
     }
 
+    if (mempool_opts.full_rbf) {
+        nLocalServices = ServiceFlags(nLocalServices | NODE_REPLACE_BY_FEE);
+    }
+
     for (bool fLoaded = false; !fLoaded && !ShutdownRequested(node);) {
         bilingual_str mempool_error;
         node.mempool = std::make_unique<CTxMemPool>(mempool_opts, mempool_error);

test/functional/p2p_node_network_limited.py

@@ -14,6 +14,7 @@
     NODE_NETWORK_LIMITED,
     NODE_P2P_V2,
     NODE_WITNESS,
+    NODE_REPLACE_BY_FEE,
     msg_getdata,
 )
 from test_framework.p2p import P2PInterface
@@ -118,7 +119,7 @@ def test_avoid_requesting_historical_blocks(self):
     def run_test(self):
         node = self.nodes[0].add_p2p_connection(P2PIgnoreInv())
 
-        expected_services = NODE_WITNESS | NODE_NETWORK_LIMITED
+        expected_services = NODE_WITNESS | NODE_NETWORK_LIMITED | NODE_REPLACE_BY_FEE
         if self.options.v2transport:
             expected_services |= NODE_P2P_V2