wallet: Move IsKeyActive to LegacyDataSPKM

Author: luke-jr

src/wallet/scriptpubkeyman.cpp

@@ -402,7 +402,7 @@ std::vector<WalletDestination> LegacyScriptPubKeyMan::MarkUnusedAddresses(const
     return result;
 }
 
-bool LegacyScriptPubKeyMan::IsKeyActive(const CScript& script) const
+bool LegacyDataSPKM::IsKeyActive(const CScript& script) const
 {
     LOCK(cs_KeyStore);
 

src/wallet/scriptpubkeyman.h

@@ -316,6 +316,7 @@ class LegacyDataSPKM : public ScriptPubKeyMan, public FillableSigningProvider
 
     // ScriptPubKeyMan overrides
     bool CheckDecryptionKey(const CKeyingMaterial& master_key) override;
+    [[nodiscard]] bool IsKeyActive(const CScript& script) const override;
     std::unordered_set<CScript, SaltedSipHasher> GetScriptPubKeys() const override;
     std::unique_ptr<SigningProvider> GetSolvingProvider(const CScript& script) const override;
     uint256 GetID() const override { return uint256::ONE; }
@@ -465,8 +466,6 @@ class LegacyScriptPubKeyMan : public LegacyDataSPKM
 
     std::vector<WalletDestination> MarkUnusedAddresses(const CScript& script) override;
 
-    [[nodiscard]] bool IsKeyActive(const CScript& script) const override;
-
     //! Upgrade stored CKeyMetadata objects to store key origin info as KeyOriginInfo
     void UpgradeKeyMetadata();