cmake: Check -Wno-* compiler options for leveldb target

hebasto · hebasto · commit 9e4a4b483221 · 2024-11-25T20:24:18.000Z
Check for -Wfoo rather than -Wno-foo because the latter may not cause
the test to fail.
diff --git a/cmake/leveldb.cmake b/cmake/leveldb.cmake
@@ -88,9 +88,11 @@ if(MSVC)
     _CRT_NONSTDC_NO_WARNINGS
   )
 else()
-  target_compile_options(nowarn_leveldb_interface INTERFACE
-    -Wno-conditional-uninitialized
-    -Wno-suggest-override
+  try_append_cxx_flags("-Wconditional-uninitialized" TARGET nowarn_leveldb_interface SKIP_LINK
+    IF_CHECK_PASSED "-Wno-conditional-uninitialized"
+  )
+  try_append_cxx_flags("-Wsuggest-override" TARGET nowarn_leveldb_interface SKIP_LINK
+    IF_CHECK_PASSED "-Wno-suggest-override"
   )
 endif()
 

Original file line number	Diff line number	Diff line change
`@@ -88,9 +88,11 @@ if(MSVC)`
`88`	`88`	`_CRT_NONSTDC_NO_WARNINGS`
`89`	`89`	`)`
`90`	`90`	`else()`
`91`		`- target_compile_options(nowarn_leveldb_interface INTERFACE`
`92`		`- -Wno-conditional-uninitialized`
`93`		`- -Wno-suggest-override`
	`91`	`+ try_append_cxx_flags("-Wconditional-uninitialized" TARGET nowarn_leveldb_interface SKIP_LINK`
	`92`	`+ IF_CHECK_PASSED "-Wno-conditional-uninitialized"`
	`93`	`+ )`
	`94`	`+ try_append_cxx_flags("-Wsuggest-override" TARGET nowarn_leveldb_interface SKIP_LINK`
	`95`	`+ IF_CHECK_PASSED "-Wno-suggest-override"`
`94`	`96`	`)`
`95`	`97`	`endif()`
`96`	`98`