RPC/Wallet: Check for negative min_conf in FundTransaction

luke-jr · luke-jr · commit a16d1512f468 · 2023-08-15T00:22:00.000Z
diff --git a/src/wallet/rpc/spend.cpp b/src/wallet/rpc/spend.cpp
@@ -611,7 +611,12 @@ void FundTransaction(CWallet& wallet, CMutableTransaction& tx, CAmount& fee_out,
             if (options.exists("minconf")) {
                 throw JSONRPCError(RPC_INVALID_PARAMETER, "min_conf and minconf options should not both be set. Use minconf (min_conf is deprecated).");
             }
+
             coinControl.m_min_depth = options["min_conf"].getInt<int>();
+
+            if (coinControl.m_min_depth < 0) {
+                throw JSONRPCError(RPC_INVALID_PARAMETER, "Negative min_conf");
+            }
         }
 
         if (options.exists("maxconf")) {

Original file line number	Diff line number	Diff line change
`@@ -611,7 +611,12 @@ void FundTransaction(CWallet& wallet, CMutableTransaction& tx, CAmount& fee_out,`
`611`	`611`	`if (options.exists("minconf")) {`
`612`	`612`	`throw JSONRPCError(RPC_INVALID_PARAMETER, "min_conf and minconf options should not both be set. Use minconf (min_conf is deprecated).");`
`613`	`613`	`}`
	`614`	`+`
`614`	`615`	`coinControl.m_min_depth = options["min_conf"].getInt<int>();`
	`616`	`+`
	`617`	`+ if (coinControl.m_min_depth < 0) {`
	`618`	`+ throw JSONRPCError(RPC_INVALID_PARAMETER, "Negative min_conf");`
	`619`	`+ }`
`615`	`620`	`}`
`616`	`621`
`617`	`622`	`if (options.exists("maxconf")) {`