Bugfix: GUI: bitcoinunits: Don't make unitlist static, since it gets rebuilt every call

luke-jr · luke-jr · commit d65857b2a2db · 2023-10-17T02:18:20.000Z
diff --git a/src/qt/bitcoinunits.cpp b/src/qt/bitcoinunits.cpp
@@ -22,7 +22,7 @@ BitcoinUnits::BitcoinUnits(QObject *parent):
 
 QList<BitcoinUnit> BitcoinUnits::availableUnits()
 {
-    static QList<BitcoinUnit> unitlist;
+    QList<BitcoinUnit> unitlist;
     unitlist.append(Unit::BTC);
     unitlist.append(Unit::mBTC);
     unitlist.append(Unit::uBTC);

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ BitcoinUnits::BitcoinUnits(QObject *parent):`
`22`	`22`
`23`	`23`	`QList<BitcoinUnit> BitcoinUnits::availableUnits()`
`24`	`24`	`{`
`25`		`- static QList<BitcoinUnit> unitlist;`
	`25`	`+ QList<BitcoinUnit> unitlist;`
`26`	`26`	`unitlist.append(Unit::BTC);`
`27`	`27`	`unitlist.append(Unit::mBTC);`
`28`	`28`	`unitlist.append(Unit::uBTC);`