Skip to content

Commit daae8b8

Browse files
committed
Merge bitcoin#18649: tests: Add std::locale::global to list of locale dependent functions in lint-locale-dependence.sh
54b5eb2 tests: Add std::locale::global to list of locale dependent functions in lint-locale-dependence.sh (practicalswift) Pull request description: Add `std::locale::global` to list of locale dependent functions in `lint-locale-dependence.sh`. We currently flag `setlocale(...)` as locale dependent, but prior to this commit we didn't flag `std::locale::global(...)` as such. In addition to setting the global C++ locale `std::locale::global(...)` also does the equivalent of `std::setlocale(LC_ALL, ...);`. Thus the functionality of `std::locale::global(...)` is a superset of `setlocale(...)` :) ACKs for top commit: MarcoFalke: ACK 54b5eb2, fine with me Tree-SHA512: bcf2f1c765add6ed09c3debca968b75eeea81602503f109c0f76ec98635911d453f4834a39e741703c3d470f123178e8952191a9b1a3429394b99c07765dcf1f
2 parents a24806c + 54b5eb2 commit daae8b8

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

test/lint/lint-locale-dependence.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ LOCALE_DEPENDENT_FUNCTIONS=(
9797
snprintf
9898
sprintf
9999
sscanf
100+
std::locale::global
100101
std::to_string
101102
stod
102103
stof

0 commit comments

Comments
 (0)