Skip to content

Commit f0d0855

Browse files
committed
Merge bitcoin#30502: doc: add release notes for bitcoin#22729
6d33e13 doc: tor.md: use -bind=127.0.0.1:8334=onion for the Tor bind (David Gumberg) a7f5d18 doc: add release notes for bitcoin#22729 (Vasil Dimov) Pull request description: Add release notes for bitcoin#22729. ACKs for top commit: davidgumberg: reACK bitcoin@6d33e13 willcl-ark: ACK 6d33e13 Tree-SHA512: 9d7e66ee1d0bb1d75b8273707d30f20915d5040a768c2c5cd47c84997df2645c8bec35db6c09dc77ab917836622411b924373816cbc83c4be38e2e9156a139d8
2 parents 1a19a4d + 6d33e13 commit f0d0855

File tree

2 files changed

+22
-1
lines changed

2 files changed

+22
-1
lines changed

doc/release-notes-22729.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
Notable changes
2+
===============
3+
4+
P2P and network changes
5+
-----------------------
6+
7+
- Previously if Bitcoin Core was listening for P2P connections, either using
8+
default settings or via `bind=addr:port` it would always also bind to
9+
`127.0.0.1:8334` to listen for Tor connections. It was not possible to switch
10+
this off, even if the node didn't use Tor. This has been changed and now
11+
`bind=addr:port` results in binding on `addr:port` only. The default behavior
12+
of binding to `0.0.0.0:8333` and `127.0.0.1:8334` has not been changed.
13+
14+
If you are using a `bind=...` configuration without `bind=...=onion` and rely
15+
on the previous implied behavior to accept incoming Tor connections at
16+
`127.0.0.1:8334`, you need to now make this explicit by using
17+
`bind=... bind=127.0.0.1:8334=onion`. (#22729)
18+
19+
- Bitcoin Core will now fail to start up if any of its P2P binds fail, rather
20+
than the previous behaviour where it would only abort startup if all P2P
21+
binds had failed. (#22729)

doc/tor.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ In a typical situation, where you're only reachable via Tor, this should suffice
193193
listen on all devices and another node could establish a clearnet connection, when knowing
194194
your address. To mitigate this, additionally bind the address of your Tor proxy:
195195

196-
./bitcoind ... -bind=127.0.0.1
196+
./bitcoind ... -bind=127.0.0.1:8334=onion
197197

198198
If you don't care too much about hiding your node, and want to be reachable on IPv4
199199
as well, use `discover` instead:

0 commit comments

Comments
 (0)