Merge #18809: rpc: Do not advertise dumptxoutset as a way to flush the chainstate

MarcoFalke · MarcoFalke · commit 00c1a4d9a95e · 2020-04-30T07:20:14.000-04:00
fac0cf6 rpc: Do not advertise dumptxoutset as a way to flush the chainstate (MarcoFalke) Pull request description: The help message leaks several implementation details: leveldb and flush. Neither of them are relevant to the end user and I don't see why we should make them part of the API contract. ACKs for top commit: laanwj: ACK fac0cf6 Tree-SHA512: 273fb85dc5be6cdccf17c43f183fa83c57d0a1cbb30555838f32c074218b713a753930009f6c98c85659421f2285f09c0a713b22f7e34d446e56737ac03870f7
diff --git a/src/rpc/blockchain.cpp b/src/rpc/blockchain.cpp
@@ -2242,8 +2242,7 @@ UniValue dumptxoutset(const JSONRPCRequest& request)
 {
     RPCHelpMan{
         "dumptxoutset",
-        "\nWrite the serialized UTXO set to disk.\n"
-        "Incidentally flushes the latest coinsdb (leveldb) to disk.\n",
+        "\nWrite the serialized UTXO set to disk.\n",
         {
             {"path",
                 RPCArg::Type::STR,

Original file line number	Diff line number	Diff line change
`@@ -2242,8 +2242,7 @@ UniValue dumptxoutset(const JSONRPCRequest& request)`
`2242`	`2242`	`{`
`2243`	`2243`	`RPCHelpMan{`
`2244`	`2244`	`"dumptxoutset",`
`2245`		`- "\nWrite the serialized UTXO set to disk.\n"`
`2246`		`- "Incidentally flushes the latest coinsdb (leveldb) to disk.\n",`
	`2245`	`+ "\nWrite the serialized UTXO set to disk.\n",`
`2247`	`2246`	`{`
`2248`	`2247`	`{"path",`
`2249`	`2248`	`RPCArg::Type::STR,`