Skip to content

Commit 00e76db

Browse files
committed
Merge pull request #6085
b05a89b Non-grammatical language improvements (Luke Dashjr) 7e6d23b Bugfix: Grammar fixes (Corinne Dashjr)
2 parents aa9fa93 + b05a89b commit 00e76db

36 files changed

+111
-109
lines changed

doc/README_osx.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Deterministic OSX Dmg Notes.
22

3-
Working OSX DMG's are created in Linux by combining a recent clang,
3+
Working OSX DMGs are created in Linux by combining a recent clang,
44
the Apple's binutils (ld, ar, etc), and DMG authoring tools.
55

66
Apple uses clang extensively for development and has upstreamed the necessary
@@ -58,7 +58,7 @@ libdmg-hfsplus project is used to compress it. There are several bugs in this
5858
tool and its maintainer has seemingly abandoned the project. It has been forked
5959
and is available (with fixes) here: https://github.com/theuni/libdmg-hfsplus .
6060

61-
The 'dmg' tool has the ability to create DMG's from scratch as well, but this
61+
The 'dmg' tool has the ability to create DMGs from scratch as well, but this
6262
functionality is broken. Only the compression feature is currently used.
6363
Ideally, the creation could be fixed and genisoimage would no longer be necessary.
6464

doc/bips.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ BIPs that are implemented by Bitcoin Core (up-to-date up to **v0.10.0**):
1111
* [`BIP 31`](https://github.com/bitcoin/bips/blob/master/bip-0031.mediawiki): The 'pong' protocol message (and the protocol version bump to 60001) has been implemented since **v0.6.1** ([PR #1081](https://github.com/bitcoin/bitcoin/pull/1081)).
1212
* [`BIP 34`](https://github.com/bitcoin/bips/blob/master/bip-0034.mediawiki): The rule that requires blocks to contain their height (number) in the coinbase input, and the introduction of version 2 blocks has been implemented since **v0.7.0**. The rule took effect for version 2 blocks as of *block 224413* (March 5th 2013), and version 1 blocks are no longer allowed since *block 227931* (March 25th 2013) ([PR #1526](https://github.com/bitcoin/bitcoin/pull/1526)).
1313
* [`BIP 35`](https://github.com/bitcoin/bips/blob/master/bip-0035.mediawiki): The 'mempool' protocol message (and the protocol version bump to 60002) has been implemented since **v0.7.0** ([PR #1641](https://github.com/bitcoin/bitcoin/pull/1641)).
14-
* [`BIP 37`](https://github.com/bitcoin/bips/blob/master/bip-0037.mediawiki): The bloom filtering for transaction relaying, partial merkle trees for blocks , and the protocol version bump to 70001 (enabling low-bandwidth SPV clients) has been implemented since **v0.8.0** ([PR #1795](https://github.com/bitcoin/bitcoin/pull/1795)).
14+
* [`BIP 37`](https://github.com/bitcoin/bips/blob/master/bip-0037.mediawiki): The bloom filtering for transaction relaying, partial merkle trees for blocks, and the protocol version bump to 70001 (enabling low-bandwidth SPV clients) has been implemented since **v0.8.0** ([PR #1795](https://github.com/bitcoin/bitcoin/pull/1795)).
1515
* [`BIP 42`](https://github.com/bitcoin/bips/blob/master/bip-0042.mediawiki): The bug that would have caused the subsidy schedule to resume after block 13440000 was fixed in **v0.9.2** ([PR #3842](https://github.com/bitcoin/bitcoin/pull/3842)).
1616
* [`BIP 61`](https://github.com/bitcoin/bips/blob/master/bip-0061.mediawiki): The 'reject' protocol message (and the protocol version bump to 70002) was added in **v0.9.0** ([PR #3185](https://github.com/bitcoin/bitcoin/pull/3185)).
1717
* [`BIP 66`](https://github.com/bitcoin/bips/blob/master/bip-0066.mediawiki): The strict DER rules and associated version 3 blocks have been implemented since **v0.10.0** ([PR #5713](https://github.com/bitcoin/bitcoin/pull/5713)).

doc/build-osx.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Mac OS X Build Instructions and Notes
22
====================================
3-
This guide will show you how to build bitcoind(headless client) for OSX.
3+
This guide will show you how to build bitcoind (headless client) for OSX.
44

55
Notes
66
-----

doc/build-unix.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -195,12 +195,12 @@ Hardening enables the following features:
195195

196196
* Position Independent Executable
197197
Build position independent code to take advantage of Address Space Layout Randomization
198-
offered by some kernels. An attacker who is able to cause execution of code at an arbitrary
199-
memory location is thwarted if he or she doesn't know where anything useful is located.
198+
offered by some kernels. Attackers who can cause execution of code at an arbitrary memory
199+
location are thwarted if they don't know where anything useful is located.
200200
The stack and heap are randomly located by default but this allows the code section to be
201201
randomly located as well.
202202

203-
On an Amd64 processor where a library was not compiled with -fPIC, this will cause an error
203+
On an AMD64 processor where a library was not compiled with -fPIC, this will cause an error
204204
such as: "relocation R_X86_64_32 against `......' can not be used when making a shared object;"
205205

206206
To test that you have built PIE executable, install scanelf, part of paxutils, and use:

doc/developer-notes.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ bool function(int arg1, const char *arg2)
5353
```
5454
A complete list of `@xxx` commands can be found at http://www.stack.nl/~dimitri/doxygen/manual/commands.html.
5555
As Doxygen recognizes the comments by the delimiters (`/**` and `*/` in this case), you don't
56-
*need* to provide any commands for a comment to be valid, just a description text is fine.
56+
*need* to provide any commands for a comment to be valid; just a description text is fine.
5757

5858
To describe a class use the same construct above the class definition:
5959
```c++
@@ -175,12 +175,12 @@ Threads
175175
Pull Request Terminology
176176
------------------------
177177

178-
Concept ACK - Agree with the idea and overall direction, but haven't reviewed the code changes or tested them.
178+
Concept ACK - Agree with the idea and overall direction, but have neither reviewed nor tested the code changes.
179179

180180
utACK (untested ACK) - Reviewed and agree with the code changes but haven't actually tested them.
181181

182182
Tested ACK - Reviewed the code changes and have verified the functionality or bug fix.
183183

184184
ACK - A loose ACK can be confusing. It's best to avoid them unless it's a documentation/comment only change in which case there is nothing to test/verify; therefore the tested/untested distinction is not there.
185185

186-
NACK - Disagree with the code changes/concept. Should be accompanied by an explanation.
186+
NACK - Disagree with the code changes/concept. Should be accompanied by an explanation.

doc/dnsseed-policy.md

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,14 @@ Other implementations of Bitcoin software may also use the same
1010
seeds and may be more exposed. In light of this exposure, this
1111
document establishes some basic expectations for operating dnsseeds.
1212

13-
0. A DNS seed operating organization or person is expected
14-
to follow good host security practices and maintain control of
15-
their serving infrastructure and not sell or transfer control of their
16-
DNS seed. Any hosting services contracted by the operator are
17-
equally expected to uphold these expectations.
13+
0. A DNS seed operating organization or person is expected to follow good
14+
host security practices, maintain control of applicable infrastructure,
15+
and not sell or transfer control of the DNS seed. Any hosting services
16+
contracted by the operator are equally expected to uphold these expectations.
1817

1918
1. The DNS seed results must consist exclusively of fairly selected and
2019
functioning Bitcoin nodes from the public network to the best of the
21-
operators understanding and capability.
20+
operator's understanding and capability.
2221

2322
2. For the avoidance of doubt, the results may be randomized but must not
2423
single-out any group of hosts to receive different results unless due to an
@@ -28,7 +27,7 @@ urgent technical necessity and disclosed.
2827

2928
4. Any logging of DNS queries should be only that which is necessary
3029
for the operation of the service or urgent health of the Bitcoin
31-
network and must not be retained longer than necessary or disclosed
30+
network and must not be retained longer than necessary nor disclosed
3231
to any third party.
3332

3433
5. Information gathered as a result of the operators node-spidering

doc/gitian-building.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ After creating the VM, we need to configure it.
8787

8888
![](gitian-building/network_settings.png)
8989

90-
- Click `Advanced`, then `Port Forwarding`. We want to set up a port through where we can reach the VM to get files in and out.
90+
- Click `Advanced`, then `Port Forwarding`. We want to set up a port through which we can reach the VM to get files in and out.
9191
- Create a new rule by clicking the plus icon.
9292

9393
![](gitian-building/port_forwarding_rules.png)
@@ -111,7 +111,7 @@ Installing Debian
111111

112112
This section will explain how to install Debian on the newly created VM.
113113

114-
- Choose the non-graphical installer. We do not need the graphical environment, it will only increase installation time and disk usage.
114+
- Choose the non-graphical installer. We do not need the graphical environment; it will only increase installation time and disk usage.
115115

116116
![](gitian-building/debian_install_1_boot_menu.png)
117117

@@ -144,7 +144,7 @@ and proceed, just press `Enter`. To select a different button, press `Tab`.
144144

145145
![](gitian-building/debian_install_9_user_password.png)
146146

147-
- The installer will set up the clock using a time server, this process should be automatic
147+
- The installer will set up the clock using a time server; this process should be automatic
148148
- Set up the clock: choose a time zone (depends on the locale settings that you picked earlier; specifics don't matter)
149149

150150
![](gitian-building/debian_install_10_configure_clock.png)
@@ -371,7 +371,7 @@ COMMIT=2014_03_windows_unicode_path
371371
Signing externally
372372
-------------------
373373

374-
If you want to do the PGP signing on another device that's also possible; just define `SIGNER` as mentioned
374+
If you want to do the PGP signing on another device, that's also possible; just define `SIGNER` as mentioned
375375
and follow the steps in the build process as normal.
376376

377377
gpg: skipped "laanwj": secret key not available
@@ -393,4 +393,4 @@ Uploading signatures
393393

394394
After building and signing you can push your signatures (both the `.assert` and `.assert.sig` files) to the
395395
[bitcoin/gitian.sigs](https://github.com/bitcoin/gitian.sigs/) repository, or if that's not possible create a pull
396-
request. You can also mail the files to me ([email protected]) and I'll commit them.
396+
request. You can also mail the files to Wladimir ([email protected]) and he will commit them.

doc/init.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ can then be controlled by group membership.
6363

6464
4a) systemd
6565

66-
Installing this .service file consists on just copying it to
66+
Installing this .service file consists of just copying it to
6767
/usr/lib/systemd/system directory, followed by the command
6868
"systemctl daemon-reload" in order to update running systemd configuration.
6969

doc/release-process.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,4 +164,4 @@ Note: check that SHA256SUMS itself doesn't end up in SHA256SUMS, which is a spur
164164

165165
- Add release notes for the new version to the directory `doc/release-notes` in git master
166166

167-
- Celebrate
167+
- Celebrate

doc/translation_process.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ QToolBar *toolbar = addToolBar(tr("Tabs toolbar"));
3232
### Creating a pull-request
3333
For general PRs, you shouldn’t include any updates to the translation source files. They will be updated periodically, primarily around pre-releases, allowing time for any new phrases to be translated before public releases. This is also important in avoiding translation related merge conflicts.
3434

35-
When an updated source file is merged into the Github repo, Transifex will automatically detect it (although it can take several hours). Once processed, the new strings will show up as "Remaining" in the Transifex web interface and are ready for translators.
35+
When an updated source file is merged into the Github repo, Transifex will automatically detect it (although it can take several hours). Once processed, the new strings will show up as "Remaining" in the Transifex web interface and are ready for translators.
3636

3737
To create the pull-request, use the following commands:
3838
```
@@ -108,4 +108,4 @@ To create a new language template, you will need to edit the languages manifest
108108
### Questions and general assistance
109109
The Bitcoin-Core translation maintainers include *tcatm, seone, Diapolo, wumpus and luke-jr*.You can find them, and others, in the Freenode IRC chatroom - `irc.freenode.net #bitcoin-dev`.
110110

111-
If you are a translator, you should also subscribe to the mailing list, https://groups.google.com/forum/#!forum/bitcoin-translators. Announcements will be posted during application pre-releases to notify translators to check for updates.
111+
If you are a translator, you should also subscribe to the mailing list, https://groups.google.com/forum/#!forum/bitcoin-translators. Announcements will be posted during application pre-releases to notify translators to check for updates.

0 commit comments

Comments
 (0)