Skip to content

Commit 0166883

Browse files
committed
Merge #17660: build: remove deprecated key from macOS Info.plist
c0bc453 build: remove deprecated key from macOS Info.plist (fanquake) Pull request description: Note that the current release binaries show correct version numbers everywhere in the GUI and macOS info dialogs (except for when you "space" click the app, shown in screenshots), and we haven't reintroduced the issue that #14701 fixed. This is just swapping a deprecated field for a newer one, as well as using the entire version string in two fields that we hadn't been previously. Follows up discussion in #14701. 0.19.0.1 ![0 19 0 1](https://user-images.githubusercontent.com/863730/70089170-a0576e80-15e5-11ea-975c-a6902a1ed95a.png) This PR. ![master](https://user-images.githubusercontent.com/863730/70089178-a3525f00-15e5-11ea-9d63-7db67de014a5.png) ACKs for top commit: laanwj: ACK c0bc453 Tree-SHA512: 6191056d0cb6072b8a2170c8441ebfe500cf00cd41014bf5ee68fbf60b5bb5642e2fad9541f1c5abfaafdae6db3102c3add6169cefce3fc4a63d8b913ea35865
2 parents adea5e1 + c0bc453 commit 0166883

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

share/qt/Info.plist.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<key>CFBundlePackageType</key>
1717
<string>APPL</string>
1818

19-
<key>CFBundleGetInfoString</key>
19+
<key>NSHumanReadableCopyright</key>
2020
<string>@CLIENT_VERSION_MAJOR@.@CLIENT_VERSION_MINOR@.@CLIENT_VERSION_REVISION@.@CLIENT_VERSION_BUILD@, Copyright © 2009-@COPYRIGHT_YEAR@ @COPYRIGHT_HOLDERS_FINAL@</string>
2121

2222
<key>CFBundleShortVersionString</key>

0 commit comments

Comments
 (0)