Merge #18999: log: Remove "No rpcpassword set" from logs

fanquake · fanquake · commit 042ff521421f · 2020-05-19T15:41:21.000+08:00
fa243be log: Remove "No rpcpassword set" from logs (MarcoFalke) Pull request description: rpcpassword is deprecated and not recommended anymore. So remove it from the logs, which indicate that an rpcpassword should be set and cause confusion. See #18998. ACKs for top commit: ryanofsky: Code review ACK fa243be. New log message makes more sense elichai: Re Code Review ACK (Checked the diff) fa243be Tree-SHA512: de3e0800a204b15a59a59a7e6f345013ee9d38e8c5d0c9a94d6142780faa9cce672ed358c7571f53c1eb843bf5afb0b7bcbfd289d3b9e2e0bf8ff2fd361e98a9
diff --git a/src/httprpc.cpp b/src/httprpc.cpp
@@ -249,7 +249,7 @@ static bool InitRPCAuthentication()
 {
     if (gArgs.GetArg("-rpcpassword", "") == "")
     {
-        LogPrintf("No rpcpassword set - using random cookie authentication.\n");
+        LogPrintf("Using random cookie authentication.\n");
         if (!GenerateAuthCookie(&strRPCUserColonPass)) {
             uiInterface.ThreadSafeMessageBox(
                 _("Error: A fatal internal error occurred, see debug.log for details"), // Same message as AbortNode

Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,7 @@ static bool InitRPCAuthentication()`
`249`	`249`	`{`
`250`	`250`	`if (gArgs.GetArg("-rpcpassword", "") == "")`
`251`	`251`	`{`
`252`		`- LogPrintf("No rpcpassword set - using random cookie authentication.\n");`
	`252`	`+ LogPrintf("Using random cookie authentication.\n");`
`253`	`253`	`if (!GenerateAuthCookie(&strRPCUserColonPass)) {`
`254`	`254`	`uiInterface.ThreadSafeMessageBox(`
`255`	`255`	`_("Error: A fatal internal error occurred, see debug.log for details"), // Same message as AbortNode`