test: Remove const to work around compiler error on xenial

laanwj · laanwj · commit 050e2ee6f28e · 2020-05-14T18:40:57.000+02:00
Fix the following error in travis:

    test/validationinterface_tests.cpp:26:36: error: default initialization of an object of const type 'const BlockValidationState' without a user-provided default constructor

    const BlockValidationState state_dummy;
diff --git a/src/test/validationinterface_tests.cpp b/src/test/validationinterface_tests.cpp
@@ -23,7 +23,7 @@ BOOST_AUTO_TEST_CASE(unregister_validation_interface_race)
     // Start thread to generate notifications
     std::thread gen{[&] {
         const CBlock block_dummy;
-        const BlockValidationState state_dummy;
+        BlockValidationState state_dummy;
         while (generate) {
             GetMainSignals().BlockChecked(block_dummy, state_dummy);
         }

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ BOOST_AUTO_TEST_CASE(unregister_validation_interface_race)`
`23`	`23`	`// Start thread to generate notifications`
`24`	`24`	`std::thread gen{[&] {`
`25`	`25`	`const CBlock block_dummy;`
`26`		`- const BlockValidationState state_dummy;`
	`26`	`+ BlockValidationState state_dummy;`
`27`	`27`	`while (generate) {`
`28`	`28`	`GetMainSignals().BlockChecked(block_dummy, state_dummy);`
`29`	`29`	`}`