Skip to content

Commit 05bfee3

Browse files
committed
util_SettingsMerge test cleanup
Followup to #15869. Treat "-wallet" as the network-specific argument in test instead of "-server", to make test output clearer and be more consistent with bitcoind. Update embedded hash to match changed output from this.
1 parent b2a6b02 commit 05bfee3

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/test/util_tests.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -580,7 +580,7 @@ BOOST_AUTO_TEST_CASE(util_GetChainName)
580580

581581
// Test different ways settings can be merged, and verify results. This test can
582582
// be used to confirm that updates to settings code don't change behavior
583-
// unintentially.
583+
// unintentionally.
584584
//
585585
// The test covers:
586586
//
@@ -687,7 +687,7 @@ struct SettingsMergeTestingSetup : public BasicTestingSetup {
687687
// Regression test covering different ways config settings can be merged. The
688688
// test parses and merges settings, representing the results as strings that get
689689
// compared against an expected hash. To debug, the result strings can be dumped
690-
// to a file (see below).
690+
// to a file (see comments below).
691691
BOOST_FIXTURE_TEST_CASE(util_SettingsMerge, SettingsMergeTestingSetup)
692692
{
693693
CHash256 out_sha;
@@ -706,7 +706,7 @@ BOOST_FIXTURE_TEST_CASE(util_SettingsMerge, SettingsMergeTestingSetup)
706706
desc += network;
707707
parser.m_network = network;
708708

709-
const std::string& name = net_specific ? "server" : "wallet";
709+
const std::string& name = net_specific ? "wallet" : "server";
710710
const std::string key = "-" + name;
711711
parser.AddArg(key, name, false, OptionsCategory::OPTIONS);
712712
if (net_specific) parser.SetNetworkOnlyArg(key);
@@ -801,7 +801,7 @@ BOOST_FIXTURE_TEST_CASE(util_SettingsMerge, SettingsMergeTestingSetup)
801801
// Results file is formatted like:
802802
//
803803
// <input> || <IsArgSet/IsArgNegated/GetArg output> | <GetArgs output> | <GetUnsuitable output>
804-
BOOST_CHECK_EQUAL(out_sha_hex, "80964e17fbd3c5569d3c824d032e28e2d319ef57494735b0e76eb7aad9957f2c");
804+
BOOST_CHECK_EQUAL(out_sha_hex, "f4281d9bff4c0b398ff118386e3a40caa6bac7645e17b296d6a10b95bff632ae");
805805
}
806806

807807
BOOST_AUTO_TEST_CASE(util_FormatMoney)

0 commit comments

Comments
 (0)