Skip to content

Commit 05c08c6

Browse files
committed
gui: add network column in peers tab/window
1 parent e0e5506 commit 05c08c6

File tree

2 files changed

+16
-9
lines changed

2 files changed

+16
-9
lines changed

src/qt/peertablemodel.cpp

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,16 @@ bool NodeLessThan::operator()(const CNodeCombinedStats &left, const CNodeCombine
2929
return pLeft->nodeid < pRight->nodeid;
3030
case PeerTableModel::Address:
3131
return pLeft->addrName.compare(pRight->addrName) < 0;
32-
case PeerTableModel::Subversion:
33-
return pLeft->cleanSubVer.compare(pRight->cleanSubVer) < 0;
32+
case PeerTableModel::Network:
33+
return pLeft->m_network < pRight->m_network;
3434
case PeerTableModel::Ping:
3535
return pLeft->m_min_ping_usec < pRight->m_min_ping_usec;
3636
case PeerTableModel::Sent:
3737
return pLeft->nSendBytes < pRight->nSendBytes;
3838
case PeerTableModel::Received:
3939
return pLeft->nRecvBytes < pRight->nRecvBytes;
40+
case PeerTableModel::Subversion:
41+
return pLeft->cleanSubVer.compare(pRight->cleanSubVer) < 0;
4042
}
4143

4244
return false;
@@ -104,7 +106,7 @@ PeerTableModel::PeerTableModel(interfaces::Node& node, QObject* parent) :
104106
m_node(node),
105107
timer(nullptr)
106108
{
107-
columns << tr("NodeId") << tr("Node/Service") << tr("Ping") << tr("Sent") << tr("Received") << tr("User Agent");
109+
columns << tr("NodeId") << tr("Node/Service") << tr("Network") << tr("Ping") << tr("Sent") << tr("Received") << tr("User Agent");
108110
priv.reset(new PeerTablePriv());
109111

110112
// set up timer for auto refresh
@@ -158,17 +160,21 @@ QVariant PeerTableModel::data(const QModelIndex &index, int role) const
158160
case Address:
159161
// prepend to peer address down-arrow symbol for inbound connection and up-arrow for outbound connection
160162
return QString(rec->nodeStats.fInbound ? "" : "") + QString::fromStdString(rec->nodeStats.addrName);
161-
case Subversion:
162-
return QString::fromStdString(rec->nodeStats.cleanSubVer);
163+
case Network:
164+
return GUIUtil::NetworkToQString(rec->nodeStats.m_network);
163165
case Ping:
164166
return GUIUtil::formatPingTime(rec->nodeStats.m_min_ping_usec);
165167
case Sent:
166168
return GUIUtil::formatBytes(rec->nodeStats.nSendBytes);
167169
case Received:
168170
return GUIUtil::formatBytes(rec->nodeStats.nRecvBytes);
171+
case Subversion:
172+
return QString::fromStdString(rec->nodeStats.cleanSubVer);
169173
}
170174
} else if (role == Qt::TextAlignmentRole) {
171175
switch (index.column()) {
176+
case Network:
177+
return QVariant(Qt::AlignCenter);
172178
case Ping:
173179
case Sent:
174180
case Received:

src/qt/peertablemodel.h

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,11 @@ class PeerTableModel : public QAbstractTableModel
6060
enum ColumnIndex {
6161
NetNodeId = 0,
6262
Address = 1,
63-
Ping = 2,
64-
Sent = 3,
65-
Received = 4,
66-
Subversion = 5
63+
Network = 2,
64+
Ping = 3,
65+
Sent = 4,
66+
Received = 5,
67+
Subversion = 6
6768
};
6869

6970
/** @name Methods overridden from QAbstractTableModel

0 commit comments

Comments
 (0)