Skip to content

Commit 0baf4b1

Browse files
author
MarcoFalke
committed
Merge #15683: Comment for seemingly duplicate LIBBITCOIN_SERVER
2a1408c Comment for seemingly duplicate LIBBITCOIN_SERVER (Peter Bushnell) Pull request description: Added a comment to explain the addition of LIBBITCOIN_SERVER twice in bitcoind_LDADD which seems incorrect at a glance until the behaviour of Linux linkers is understood. ACKs for commit 2a1408: practicalswift: ACK 2a1408c MarcoFalke: ACK 2a1408c fanquake: utACK 2a1408c ryanofsky: utACK 2a1408c Tree-SHA512: dd2a7f61d53ce8882a56c831c32e1f48e9eab741ef21361f195c38bb455abdc4bc524d3b44b6f69c7498898cd871a23c39d215de28db3b20ef5fd2135d5e136a
2 parents dc5c2e4 + 2a1408c commit 0baf4b1

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/Makefile.am

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -497,6 +497,8 @@ if TARGET_WINDOWS
497497
bitcoind_SOURCES += bitcoind-res.rc
498498
endif
499499

500+
# Libraries below may be listed more than once to resolve circular dependencies (see
501+
# https://eli.thegreenplace.net/2013/07/09/library-order-in-static-linking#circular-dependency)
500502
bitcoind_LDADD = \
501503
$(LIBBITCOIN_SERVER) \
502504
$(LIBBITCOIN_WALLET) \

0 commit comments

Comments
 (0)