Merge #17191: random: remove call to RAND_screen() (Windows only)

laanwj · laanwj · commit 0d6b6b7c658b · 2019-10-21T09:53:32.000+02:00
e892f96 random: remove call to RAND_screen() (Windows only) (fanquake) Pull request description: Follow up to bitcoin/bitcoin#17151 where there were multiple calls to also remove our call to RAND_screen(). ACKs for top commit: MarcoFalke: unsigned ACK e892f96 laanwj: ACK e892f96 Tree-SHA512: 1b846016d91e8113f90466b61fcaf0574edb6b4726eba1947549e2ac28907e1318d893f7b303e756f19730c8507c79b10e08d54b97153224b585ff1e0ac1953e
diff --git a/src/random.cpp b/src/random.cpp
@@ -594,10 +594,6 @@ static void SeedSleep(CSHA512& hasher, RNGState& rng)
 
 static void SeedStartup(CSHA512& hasher, RNGState& rng) noexcept
 {
-#ifdef WIN32
-    RAND_screen();
-#endif
-
     // Gather 256 bits of hardware randomness, if available
     SeedHardwareSlow(hasher);
 

Original file line number	Diff line number	Diff line change
`@@ -594,10 +594,6 @@ static void SeedSleep(CSHA512& hasher, RNGState& rng)`
`594`	`594`
`595`	`595`	`static void SeedStartup(CSHA512& hasher, RNGState& rng) noexcept`
`596`	`596`	`{`
`597`		`-#ifdef WIN32`
`598`		`- RAND_screen();`
`599`		`-#endif`
`600`		`-`
`601`	`597`	`// Gather 256 bits of hardware randomness, if available`
`602`	`598`	`SeedHardwareSlow(hasher);`
`603`	`599`