You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merge bitcoin/bitcoin#23513: ci: Drop --failfast in functional tests on native Windows CI task
23c3dcb ci: Drop --failfast in functional tests on native Windows CI task (Hennadii Stepanov)
Pull request description:
As it was [discussed](bitcoin/bitcoin#22980 (comment)) in bitcoin/bitcoin#22980:
> seeing _all_ of the failed tests can give us a useful hint for debugging (was thinking about that while reviewing and testing bitcoin/bitcoin#23300).
There is a [concern](bitcoin/bitcoin#22980 (comment)) about such approach:
> If there is a CI failure, it will be good to know the result as early as possible after opening the pull request.
But, [OTOH](bitcoin/bitcoin#22980 (comment)):
> the average amount of saved time for such an approach [using `--failfast`] is less significant than it could appear.
ACKs for top commit:
MarcoFalke:
cr ACK 23c3dcb seems fine to give this a try
Tree-SHA512: d28f5712b4edfdbcef48b0633017da9172cef1835bcea51eaeeabf15c133f6bb6888227afc130279c3899365a4fd0f200fb9b0c4cb1ff80f21cbc766b8907764
0 commit comments