Skip to content

Commit 15d1098

Browse files
author
MarcoFalke
committed
Merge bitcoin/bitcoin#23513: ci: Drop --failfast in functional tests on native Windows CI task
23c3dcb ci: Drop --failfast in functional tests on native Windows CI task (Hennadii Stepanov) Pull request description: As it was [discussed](bitcoin/bitcoin#22980 (comment)) in bitcoin/bitcoin#22980: > seeing _all_ of the failed tests can give us a useful hint for debugging (was thinking about that while reviewing and testing bitcoin/bitcoin#23300). There is a [concern](bitcoin/bitcoin#22980 (comment)) about such approach: > If there is a CI failure, it will be good to know the result as early as possible after opening the pull request. But, [OTOH](bitcoin/bitcoin#22980 (comment)): > the average amount of saved time for such an approach [using `--failfast`] is less significant than it could appear. ACKs for top commit: MarcoFalke: cr ACK 23c3dcb seems fine to give this a try Tree-SHA512: d28f5712b4edfdbcef48b0633017da9172cef1835bcea51eaeeabf15c133f6bb6888227afc130279c3899365a4fd0f200fb9b0c4cb1ff80f21cbc766b8907764
2 parents fa23039 + 23c3dcb commit 15d1098

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.cirrus.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ task:
164164
- netsh int ipv4 set dynamicport tcp start=1025 num=64511
165165
- netsh int ipv6 set dynamicport tcp start=1025 num=64511
166166
# Exclude feature_dbcrash for now due to timeout
167-
- python test\functional\test_runner.py --nocleanup --ci --quiet --combinedlogslen=4000 --jobs=4 --timeout-factor=8 --failfast --extended --exclude feature_dbcrash
167+
- python test\functional\test_runner.py --nocleanup --ci --quiet --combinedlogslen=4000 --jobs=4 --timeout-factor=8 --extended --exclude feature_dbcrash
168168

169169
task:
170170
name: 'ARM [unit tests, no functional tests] [bullseye]'

0 commit comments

Comments
 (0)