Skip to content

Commit 1887337

Browse files
committed
Add a comment explaining the use of MAX_BLOCK_BASE_SIZE.
1 parent c2ab38b commit 1887337

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

src/consensus/consensus.h

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,13 @@
1212
static const unsigned int MAX_BLOCK_SERIALIZED_SIZE = 4000000;
1313
/** The maximum allowed weight for a block, see BIP 141 (network rule) */
1414
static const unsigned int MAX_BLOCK_WEIGHT = 4000000;
15-
/** The maximum allowed size for a block excluding witness data, in bytes (network rule) */
15+
/**
16+
* The maximum allowed size for a block excluding witness data, in bytes (network rule).
17+
* This parameter is largely superfluous because it is directly implied by the above block
18+
* weight limit, even when BIP 141 is not active. It continues to exist for use in
19+
* various early tests that run before the witness data has been checked.
20+
* All tests related to it could be removed without breaking consensus compatibility.
21+
*/
1622
static const unsigned int MAX_BLOCK_BASE_SIZE = 1000000;
1723
/** The maximum allowed number of signature check operations in a block (network rule) */
1824
static const int64_t MAX_BLOCK_SIGOPS_COST = 80000;

0 commit comments

Comments
 (0)